Merge pull request #865 from alphagov/remove-noti-stats

remove unused call to notification statistics

app/main/views/send.py

@@ -28,7 +28,7 @@ from app.main.uploader import (
     s3upload,
     s3download
 )
-from app import job_api_client, service_api_client, current_service, user_api_client, statistics_api_client
+from app import job_api_client, service_api_client, current_service, user_api_client
 from app.utils import user_has_permissions, get_errors_for_csv, Spreadsheet, get_help_argument
 
 

app/notify_client/statistics_api_client.py

@@ -12,16 +12,6 @@ class StatisticsApiClient(BaseAPIClient):
         self.client_id = app.config['ADMIN_CLIENT_USER_NAME']
         self.secret = app.config['ADMIN_CLIENT_SECRET']
 
-    def get_statistics_for_service_for_day(self, service_id, day):
-        url = '/service/{}/notifications-statistics/day/{}'.format(service_id, day)
-        try:
-            return self.get(url=url)['data']
-        except HTTPError as e:
-            if e.status_code == 404:
-                return None
-            else:
-                raise e
-
     def get_statistics_for_all_services_for_day(self, day):
         params = {
             'day': day

tests/conftest.py

@@ -216,26 +216,6 @@ def mock_delete_service(mocker, mock_get_service):
         'app.service_api_client.delete_service', side_effect=_delete)
 
 
-@pytest.fixture(scope='function')
-def mock_get_service_statistics_for_day(mocker):
-
-    stats = {'day': datetime.today().date().strftime('%Y-%m-%d'),
-             'emails_delivered': 0,
-             'sms_requested': 0,
-             'sms_delivered': 0,
-             'sms_failed': 0,
-             'emails_requested': 0,
-             'emails_failed': 0,
-             'service': fake_uuid,
-             'id': fake_uuid}
-
-    def _stats(service_id, day):
-        return {'data': stats}
-
-    return mocker.patch(
-        'app.statistics_api_client.get_statistics_for_service_for_day', side_effect=_stats)
-
-
 @pytest.fixture(scope='function')
 def mock_get_all_service_statistics(mocker):
     def _create(day):