darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-05-04 16:11:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove splatting on get template methods

Browse Source 
This `*params` argument seems to be copy/pasted boilerplate. It’s not
used by any consumers of this client, and makes it harder to write a
decorator for this function.
This commit is contained in:
Chris Hill-Scott
2018-04-19 10:26:17 +01:00
parent a0d7658db1
commit 6c8fea1ee8
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/notify_client/service_api_client.py
View File

@@ -199,7 +199,7 @@ class ServiceAPIClient(NotifyAdminAPIClient):
data
)
def get_service_template(self, service_id, template_id, version=None, *params):
def get_service_template(self, service_id, template_id, version=None):
"""
Retrieve a service template.
"""
@@ -208,9 +208,9 @@ class ServiceAPIClient(NotifyAdminAPIClient):
template_id=template_id)
if version:
endpoint = '{base}/version/{version}'.format(base=endpoint, version=version)
return self.get(endpoint, *params)
return self.get(endpoint)
def get_service_template_versions(self, service_id, template_id, *params):
def get_service_template_versions(self, service_id, template_id):
"""
Retrieve a list of versions for a template
"""
@@ -218,15 +218,15 @@ class ServiceAPIClient(NotifyAdminAPIClient):
service_id=service_id,
template_id=template_id
)
return self.get(endpoint, *params)
return self.get(endpoint)
def get_service_templates(self, service_id, *params):
def get_service_templates(self, service_id):
"""
Retrieve all templates for service.
"""
endpoint = '/service/{service_id}/template'.format(
service_id=service_id)
return self.get(endpoint, *params)
return self.get(endpoint)
def count_service_templates(self, service_id, template_type=None):
return len([