darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-26 01:04:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

Added a validation for a minimum of 3 character.

Browse Source 
If the SMS sender is less than 3 characters one of our providers will return an error.
This commit is contained in:
Rebecca Law
2018-02-15 16:06:44 +00:00
parent fcc5c4e3e9
commit 6bd99e0599
2 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/main/forms.py
View File

@@ -561,6 +561,7 @@ class ServiceSmsSenderForm(StripWhitespaceForm):
validators=[ validators=[
DataRequired(message="Can’t be empty"), DataRequired(message="Can’t be empty"),
Length(max=11, message="Enter 11 characters or fewer"), Length(max=11, message="Enter 11 characters or fewer"),
Length(min=3, message="Enter 3 characters or more"),
LettersNumbersAndFullStopsOnly(), LettersNumbersAndFullStopsOnly(),
] ]
) )

4
tests/app/main/test_validators.py
View File

@@ -206,3 +206,7 @@ def test_sms_sender_form_validation(
form.sms_sender.data = '###########' form.sms_sender.data = '###########'
form.validate() form.validate()
assert 'Use letters and numbers only' == form.errors['sms_sender'][0] assert 'Use letters and numbers only' == form.errors['sms_sender'][0]
form.sms_sender.data = '0'
form.validate()
assert 'Enter 3 characters or more' == form.errors['sms_sender'][0]