darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 15:57:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1542 from alphagov/track-all-form-errors

Browse Source 
Track form validation errors in Google analytics
This commit is contained in:
Chris Hill-Scott
2017-10-17 17:06:44 +01:00
committed by GitHub
parent 184bd398f4 d5edb8dbfb
commit 6baa9fe327
4 changed files with 20 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/templates/components/list-entry.html
View File

@@ -18,7 +18,7 @@
</span> </span>
{% endif %} {% endif %}
{% if field.errors %} {% if field.errors %}
<span class="error-message"> <span class="error-message" data-module="track-error" data-error-type="{{ field.errors[0][0] }}" data-error-label="{{ field.name }}">
{{ field.errors[0][0] }} {{ field.errors[0][0] }}
</span> </span>
{% endif %} {% endif %}

6
app/templates/components/radios.html
View File

@@ -9,7 +9,7 @@
<legend class="form-label"> <legend class="form-label">
{{ field.label.text|safe }} {{ field.label.text|safe }}
{% if field.errors %} {% if field.errors %}
<span class="error-message"> <span class="error-message" data-module="track-error" data-error-type="{{ field.errors[0] }}" data-error-label="{{ field.name }}">
{{ field.errors[0] }} {{ field.errors[0] }}
</span> </span>
{% endif %} {% endif %}
@@ -50,7 +50,7 @@
<legend class="form-label"> <legend class="form-label">
{{ field.label.text }} {{ field.label.text }}
{% if field.errors %} {% if field.errors %}
<span class="error-message"> <span class="error-message" data-module="track-error" data-error-type="{{ field.errors[0] }}" data-error-label="{{ field.name }}">
{{ field.errors[0] }} {{ field.errors[0] }}
</span> </span>
{% endif %} {% endif %}
@@ -89,7 +89,7 @@
{{ field.label.text }} {{ field.label.text }}
{% endif %} {% endif %}
{% if field.errors %} {% if field.errors %}
<span class="error-message"> <span class="error-message" data-module="track-error" data-error-type="{{ field.errors[0] }}" data-error-label="{{ field.name }}">
{{ field.errors[0] }} {{ field.errors[0] }}
</span> </span>
{% endif %} {% endif %}

2
app/templates/components/textbox.html
View File

@@ -24,7 +24,7 @@
</span> </span>
{% endif %} {% endif %}
{% if field.errors %} {% if field.errors %}
<span class="error-message"> <span class="error-message" data-module="track-error" data-error-type="{{ field.errors[0] }}" data-error-label="{{ field.name }}">
{% if not safe_error_message %}{{ field.errors[0] }}{% else %}{{ field.errors[0]|safe }}{% endif %} {% if not safe_error_message %}{{ field.errors[0] }}{% else %}{{ field.errors[0]|safe }}{% endif %}
</span> </span>
{% endif %} {% endif %}

22
tests/app/main/views/test_verify.py
View File

@@ -4,6 +4,8 @@ import json
from flask import url_for from flask import url_for
from bs4 import BeautifulSoup from bs4 import BeautifulSoup
from tests.conftest import normalize_spaces
def test_should_return_verify_template( def test_should_return_verify_template(
client, client,
@@ -68,17 +70,23 @@ def test_should_activate_user_after_verify(
def test_should_return_200_when_sms_code_is_wrong( def test_should_return_200_when_sms_code_is_wrong(
client, client_request,
api_user_active, api_user_active,
mock_check_verify_code_code_not_found, mock_check_verify_code_code_not_found,
): ):
with client.session_transaction() as session: with client_request.session_transaction() as session:
session['user_details'] = {'email_address': api_user_active.email_address, 'id': api_user_active.id} session['user_details'] = {'email_address': api_user_active.email_address, 'id': api_user_active.id}
response = client.post(url_for('main.verify'),
data={'sms_code': '12345'}) page = client_request.post(
assert response.status_code == 200 'main.verify',
resp_data = response.get_data(as_text=True) _data={'sms_code': '12345'},
assert resp_data.count('Code not found') == 1 _expected_status=200,
)
assert len(page.select('.error-message')) == 1
assert normalize_spaces(page.select_one('.error-message').text) == (
'Code not found'
)
def test_verify_email_redirects_to_verify_if_token_valid( def test_verify_email_redirects_to_verify_if_token_valid(