From 6b7908fecbf9a2ac68f43b3d2282ffe0388a8519 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Wed, 16 Sep 2020 08:25:42 +0100 Subject: [PATCH] =?UTF-8?q?Don=E2=80=99t=20use=20single=20letter=20variabl?= =?UTF-8?q?e=20names?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Better to call the variables what they are. Also re-orders the statement to avoid adding to a negative number. --- app/models/broadcast_message.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/models/broadcast_message.py b/app/models/broadcast_message.py index cd49abf15..636c756c8 100644 --- a/app/models/broadcast_message.py +++ b/app/models/broadcast_message.py @@ -16,10 +16,10 @@ from app.notify_client.broadcast_message_api_client import ( from app.notify_client.service_api_client import service_api_client -def round_to_significant_figures(x, n): +def round_to_significant_figures(value, number_of_significant_figures): return int(round( - x, - -int(floor(log10(abs(x)))) + (n - 1) + value, + number_of_significant_figures - int(floor(log10(abs(value)))) - 1 ))