darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-19 14:09:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

Specify mimetype for PDF letters to be downloaded

Browse Source 
We had a report that when clicking on the 'Download this letter' link on
the notification page the file was not being downloaded as a PDF file
but was given a `.htm` file extension instead. We should be able to stop
that happening by using Flask's `send_file` function with the right mimetype.
This change updates the `view_letter_notification_as_preview` to use
`send_file` and splits out code to get the file data into a separate
function.

Mocks in the tests have been updated and some unused mocks removed.
This commit is contained in:
Katie Smith
2020-04-07 17:13:28 +01:00
parent 2992aacd8a
commit 6b055071f4
2 changed files with 20 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/app/main/views/test_notifications.py
View File

@@ -254,7 +254,7 @@ def test_notification_page_shows_uploaded_letter(
fake_uuid,
):
mocker.patch(
'app.main.views.notifications.view_letter_notification_as_preview',
'app.main.views.notifications.get_letter_file_data',
return_value=(b'foo', {
'message': '',
'invalid_pages': '[]',
@@ -319,18 +319,13 @@ def test_notification_page_shows_page_for_letter_sent_with_test_key(
if is_precompiled_letter:
mocker.patch(
'app.main.views.notifications.view_letter_notification_as_preview',
'app.main.views.notifications.get_letter_file_data',
return_value=(b'foo', {
'message': '',
'invalid_pages': '[]',
'page_count': '1'
})
)
else:
mocker.patch(
'app.main.views.notifications.view_letter_notification_as_preview',
return_value=b'foo'
)
mocker.patch(
'app.main.views.notifications.pdf_page_count',
@@ -383,7 +378,7 @@ def test_notification_page_shows_validation_failed_precompiled_letter(
metadata = {"page_count": "1", "status": "validation-failed",
"invalid_pages": "[1]",
"message": "content-outside-printable-area"}
mocker.patch('app.main.views.notifications.view_letter_notification_as_preview',
mocker.patch('app.main.views.notifications.get_letter_file_data',
return_value=("some letter content", metadata))
mocker.patch(
'app.main.views.notifications.get_page_count_for_letter',
@@ -627,7 +622,7 @@ def test_should_show_preview_error_image_letter_notification_on_preview_error(
side_effect=APIError
)
mocker.patch("builtins.open", mock_open(read_data="preview error image"))
mocker.patch("builtins.open", mock_open(read_data=b"preview error image"))
response = logged_in_client.get(url_for(
'main.view_letter_notification_as_preview',
@@ -651,7 +646,7 @@ def test_notification_page_shows_error_message_if_precompiled_letter_cannot_be_o
is_precompiled_letter=True)
mocker.patch('app.notification_api_client.get_notification', return_value=notification)
mocker.patch(
'app.main.views.notifications.view_letter_notification_as_preview',
'app.main.views.notifications.get_letter_file_data',
side_effect=PdfReadError()
)
mocker.patch(
@@ -783,14 +778,9 @@ def test_notification_page_has_expected_template_link_for_letter(
if is_precompiled_letter:
mocker.patch(
'app.main.views.notifications.view_letter_notification_as_preview',
'app.main.views.notifications.get_letter_file_data',
side_effect=[(b'foo', {"message": "", "invalid_pages": "[]", "page_count": "1"}), b'foo']
)
else:
mocker.patch(
'app.main.views.notifications.view_letter_notification_as_preview',
return_value=b'foo'
)
mocker.patch(
'app.main.views.notifications.pdf_page_count',