darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-05-05 16:38:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix issue where row_number starts from 3 on a job report download

Browse Source
This commit is contained in:
Imdad Ahad
2017-01-19 10:42:58 +00:00
parent dfc751ef02
commit 6a48325b3b
2 changed files with 32 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/app/test_utils.py
View File

@@ -124,3 +124,27 @@ def test_generate_notifications_csv_calls_twice_if_next_link(mocker):
# mock_calls[0][2] is the kwargs from first call
assert mock_get_notifications.mock_calls[0][2]['page'] == 1
assert mock_get_notifications.mock_calls[1][2]['page'] == 2
@pytest.mark.parametrize('row_number, expected_result', [
(None, ''),
(0, '1'),
(1, '2'),
(300, '301')
])
def test_generate_notifications_csv_formats_row_number_correctly(mocker, row_number, expected_result):
service_id = '1234'
response_with_job_row_zero = notification_json(service_id, rows=1, with_links=True, job_row_number=row_number)
mocker.patch(
'app.notification_api_client.get_notifications_for_service',
side_effect=[
response_with_job_row_zero
]
)
csv_content = generate_notifications_csv(service_id=service_id)
csv = DictReader(StringIO('\n'.join(csv_content)))
csv_rows = list(csv)
assert len(csv_rows) == 1
assert csv_rows[0].get('Row number') == expected_result