darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-25 10:29:14 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #936 from alphagov/fix-forgot-password-empty-user-issue

Browse Source 
Fix exception raised when a pending user attempts to complete 'forgotten password' flow
This commit is contained in:
imdadahad
2016-09-13 15:39:29 +01:00
committed by GitHub
parent 6bad0101c8 defa7ac2c8
commit 69c16cb0e4
5 changed files with 32 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/app/main/views/test_two_factor.py
View File

@@ -222,3 +222,24 @@ def test_two_factor_should_redirect_to_sign_in_if_user_not_in_session(app_,
data={'sms_code': '12345'})
assert response.status_code == 302
assert response.location == url_for('main.sign_in', _external=True)
def test_two_factor_should_activate_pending_user(app_,
mocker,
api_user_pending,
mock_check_verify_code,
mock_update_user
):
mocker.patch('app.user_api_client.get_user', return_value=api_user_pending)
mocker.patch('app.service_api_client.get_services', return_value={'data': []})
with app_.test_request_context():
with app_.test_client() as client:
with client.session_transaction() as session:
session['user_details'] = {
'id': api_user_pending.id,
'email_address': api_user_pending.email_address
}
client.post(url_for('main.two_factor'), data={'sms_code': '12345'})
assert mock_update_user.called
assert api_user_pending.is_active

7
tests/app/main/views/test_verify.py
View File

@@ -39,15 +39,16 @@ def test_should_redirect_to_add_service_when_sms_code_is_correct(app_,
def test_should_activate_user_after_verify(app_,
api_user_active,
mock_get_user,
mocker,
api_user_pending,
mock_send_verify_code,
mock_check_verify_code,
mock_update_user):
mocker.patch('app.user_api_client.get_user', return_value=api_user_pending)
with app_.test_request_context():
with app_.test_client() as client:
with client.session_transaction() as session:
session['user_details'] = {'email_address': api_user_active.email_address, 'id': api_user_active.id}
session['user_details'] = {'email_address': api_user_pending.email_address, 'id': api_user_pending.id}
client.post(url_for('main.verify'),
data={'sms_code': '12345'})
assert mock_update_user.called