mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-02-05 10:53:28 -05:00
Working tests, hopefully all code changes done.
This commit is contained in:
@@ -1,70 +1,61 @@
|
||||
from datetime import datetime, timedelta
|
||||
|
||||
from app.main.dao import verify_codes_dao
|
||||
from app.main.forms import TwoFactorForm
|
||||
from app.main.dao import users_dao
|
||||
from tests import create_test_user
|
||||
|
||||
|
||||
def test_form_is_valid_returns_no_errors(app_, db_, db_session):
|
||||
def test_form_is_valid_returns_no_errors(app_, mock_check_verify_code):
|
||||
with app_.test_request_context(method='POST',
|
||||
data={'sms_code': '12345'}) as req:
|
||||
user = set_up_test_data()
|
||||
codes = verify_codes_dao.get_codes(user.id)
|
||||
form = TwoFactorForm(codes)
|
||||
def _check_code(code):
|
||||
return users_dao.check_verify_code('1', code, "sms")
|
||||
form = TwoFactorForm(_check_code)
|
||||
assert form.validate() is True
|
||||
assert len(form.errors) == 0
|
||||
|
||||
|
||||
def test_returns_errors_when_code_is_too_short(app_, db_, db_session):
|
||||
def test_returns_errors_when_code_is_too_short(app_, mock_check_verify_code):
|
||||
with app_.test_request_context(method='POST',
|
||||
data={'sms_code': '145'}) as req:
|
||||
user = set_up_test_data()
|
||||
codes = verify_codes_dao.get_codes(user.id)
|
||||
form = TwoFactorForm(codes)
|
||||
def _check_code(code):
|
||||
return users_dao.check_verify_code('1', code, "sms")
|
||||
form = TwoFactorForm(_check_code)
|
||||
assert form.validate() is False
|
||||
assert len(form.errors) == 1
|
||||
assert set(form.errors) == set({'sms_code': ['Code must be 5 digits', 'Code does not match']})
|
||||
|
||||
|
||||
def test_returns_errors_when_code_is_missing(app_, db_, db_session):
|
||||
def test_returns_errors_when_code_is_missing(app_, mock_check_verify_code):
|
||||
with app_.test_request_context(method='POST',
|
||||
data={}) as req:
|
||||
user = set_up_test_data()
|
||||
codes = verify_codes_dao.get_codes(user.id)
|
||||
form = TwoFactorForm(codes)
|
||||
def _check_code(code):
|
||||
return users_dao.check_verify_code('1', code, "sms")
|
||||
form = TwoFactorForm(_check_code)
|
||||
assert form.validate() is False
|
||||
assert len(form.errors) == 1
|
||||
assert set(form.errors) == set({'sms_code': ['Code must not be empty']})
|
||||
|
||||
|
||||
def test_returns_errors_when_code_contains_letters(app_, db_, db_session):
|
||||
def test_returns_errors_when_code_contains_letters(app_, mock_check_verify_code):
|
||||
with app_.test_request_context(method='POST',
|
||||
data={'sms_code': 'asdfg'}) as req:
|
||||
user = set_up_test_data()
|
||||
codes = verify_codes_dao.get_codes(user.id)
|
||||
form = TwoFactorForm(codes)
|
||||
def _check_code(code):
|
||||
return users_dao.check_verify_code('1', code, "sms")
|
||||
form = TwoFactorForm(_check_code)
|
||||
assert form.validate() is False
|
||||
assert len(form.errors) == 1
|
||||
assert set(form.errors) == set({'sms_code': ['Code must be 5 digits', 'Code does not match']})
|
||||
|
||||
|
||||
def test_should_return_errors_when_code_is_expired(app_, db_, db_session):
|
||||
def test_should_return_errors_when_code_is_expired(app_,
|
||||
mock_check_verify_code_code_expired):
|
||||
with app_.test_request_context(method='POST',
|
||||
data={'sms_code': '23456'}) as req:
|
||||
user = create_test_user('active')
|
||||
verify_codes_dao.add_code_with_expiry(user_id=user.id,
|
||||
code='23456',
|
||||
code_type='sms',
|
||||
expiry=datetime.now() + timedelta(hours=-2))
|
||||
codes = verify_codes_dao.get_codes(user.id)
|
||||
form = TwoFactorForm(codes)
|
||||
def _check_code(code):
|
||||
return users_dao.check_verify_code('1', code, "sms")
|
||||
form = TwoFactorForm(_check_code)
|
||||
assert form.validate() is False
|
||||
errors = form.errors
|
||||
assert len(errors) == 1
|
||||
assert errors == {'sms_code': ['Code has expired']}
|
||||
|
||||
|
||||
def set_up_test_data():
|
||||
user = create_test_user('active')
|
||||
verify_codes_dao.add_code(user_id=user.id, code='12345', code_type='sms')
|
||||
return user
|
||||
|
||||
Reference in New Issue
Block a user