mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-05-05 16:38:59 -04:00
Make API key combination of secret and service ID
In research we’ve seen people mix up the service ID and API key because they’re both 36 character UUIDs. We can’t get rid of the service ID because it’s used to look up the API key. Instead, we should change API key to be one long string, which contains both the service ID, API key and (optionally) the name of the key. For example: ``` casework_production-8b3aa916-ec82-434e-b0c5-d5d9b371d6a3-dcdc5083-2fee-4fba-8afd-51f3f4bcb7b0 ``` We still need to keep the old, separate, key and service ID for a while until people have updated their clients. But they’re now both on this page, rather than on two separate pages, which should make for less fussing anyway. This shouldn’t be rolled out until the new clients are available. - [ ] https://github.com/alphagov/notifications-python-client/pull/36 - [ ] https://github.com/alphagov/notifications-node-client/pull/10 - [ ] https://github.com/alphagov/notifications-ruby-client/pull/15 - [ ] https://github.com/alphagov/notifications-java-client/pull/38 - [ ] PHP????
This commit is contained in:
@@ -134,10 +134,10 @@ def generate_previous_next_dict(view, service_id, page, title, url_args):
|
||||
}
|
||||
|
||||
|
||||
def email_safe(string):
|
||||
def email_safe(string, whitespace='.'):
|
||||
return "".join([
|
||||
character.lower() if character.isalnum() or character == "." else ""
|
||||
for character in re.sub(r"\s+", ".", string.strip())
|
||||
character.lower() if character.isalnum() or character == whitespace else ""
|
||||
for character in re.sub(r"\s+", whitespace, string.strip())
|
||||
])
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user