darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-02 17:48:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Give better error message for blacklisted password

Browse Source 
Telling the user what to do, rather than the mistake they’ve made is
usually better.
This commit is contained in:
Chris Hill-Scott
2016-09-27 11:37:20 +01:00
parent 136662bd30
commit 68a6ceec78
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/main/forms.py
View File

@@ -73,7 +73,7 @@ def password(label='Password'):
return PasswordField(label, return PasswordField(label,
validators=[DataRequired(message='Can’t be empty'), validators=[DataRequired(message='Can’t be empty'),
Length(8, 255, message='Must be at least 8 characters'), Length(8, 255, message='Must be at least 8 characters'),
Blacklist(message='That password is blacklisted, too common')]) Blacklist(message='Choose a password that’s harder to guess')])
def sms_code(): def sms_code():

2
tests/app/main/test_validators.py
View File

@@ -17,7 +17,7 @@ def test_should_raise_validation_error_for_password(app_, mock_get_user_by_email
form.password.data = password form.password.data = password
form.validate() form.validate()
assert 'That password is blacklisted, too common' in form.errors['password'] assert 'Choose a password that’s harder to guess' in form.errors['password']
def test_valid_email_not_in_valid_domains(app_): def test_valid_email_not_in_valid_domains(app_):