darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-06 14:48:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add addtional test cases for row errors

Browse Source
This commit is contained in:
Pea Tyczynska
2019-11-26 16:34:11 +00:00
parent f265dde8ab
commit 64b35ba337
2 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/utils.py
View File

@@ -136,14 +136,14 @@ def get_errors_for_csv(recipients, template_type):
if 1 == number_of_rows_with_message_too_long: if 1 == number_of_rows_with_message_too_long:
errors.append("shorten your message in 1 row") errors.append("shorten your message in 1 row")
else: else:
errors.append("shorten your message in {} rows".format(number_of_rows_with_missing_data)) errors.append("shorten your messages in {} rows".format(number_of_rows_with_message_too_long))
if any(recipients.rows_with_empty_message): if any(recipients.rows_with_empty_message):
number_of_rows_with_empty_message = len(list(recipients.rows_with_empty_message)) number_of_rows_with_empty_message = len(list(recipients.rows_with_empty_message))
if 1 == number_of_rows_with_empty_message: if 1 == number_of_rows_with_empty_message:
errors.append("add content to empty message in 1 row") errors.append("add content to empty message in 1 row")
else: else:
errors.append("add content to empty messages {} rows".format(number_of_rows_with_empty_message)) errors.append("add content to empty messages in {} rows".format(number_of_rows_with_empty_message))
return errors return errors

18
tests/app/main/test_errors_for_csv.py
View File

@@ -67,6 +67,13 @@ MockRecipients = namedtuple(
'shorten your message in 1 row' 'shorten your message in 1 row'
] ]
), ),
(
{}, {}, {3, 12}, [],
'sms',
[
'shorten your messages in 2 rows'
]
),
( (
{}, {}, {}, {2}, {}, {}, {}, {2},
'sms', 'sms',
@@ -74,6 +81,13 @@ MockRecipients = namedtuple(
'add content to empty message in 1 row' 'add content to empty message in 1 row'
] ]
), ),
(
{}, {}, {}, {2, 4, 8},
'sms',
[
'add content to empty messages in 3 rows'
]
),
] ]
) )
def test_get_errors_for_csv( def test_get_errors_for_csv(
@@ -82,6 +96,8 @@ def test_get_errors_for_csv(
expected_errors expected_errors
): ):
assert get_errors_for_csv( assert get_errors_for_csv(
MockRecipients(rows_with_bad_recipients, rows_with_missing_data, rows_with_message_too_long, rows_with_empty_message), MockRecipients(
rows_with_bad_recipients, rows_with_missing_data, rows_with_message_too_long, rows_with_empty_message
),
template_type template_type
) == expected_errors ) == expected_errors