darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-09 03:03:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

Change the format of the user_permissions data that gets sent

Browse Source 
The endpoint for setting permissions in api will now be used for both
user permissions and a user's folder permissions, so this changes the
format of the data we pass through.
This commit is contained in:
Katie Smith
2019-02-21 15:06:41 +00:00
parent 6ac713c978
commit 62578f5951
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/notify_client/user_api_client.py
View File

@@ -164,7 +164,10 @@ class UserApiClient(NotifyAdminAPIClient):
@cache.delete('user-{user_id}') @cache.delete('user-{user_id}')
def set_user_permissions(self, user_id, service_id, permissions): def set_user_permissions(self, user_id, service_id, permissions):
# permissions passed in are the combined admin roles, not db permissions # permissions passed in are the combined admin roles, not db permissions
data = [{'permission': x} for x in translate_permissions_from_admin_roles_to_db(permissions)] data = {
'permissions': [{'permission': x} for x in translate_permissions_from_admin_roles_to_db(permissions)]
}
endpoint = '/user/{}/service/{}/permission'.format(user_id, service_id) endpoint = '/user/{}/service/{}/permission'.format(user_id, service_id)
self.post(endpoint, data=data) self.post(endpoint, data=data)

2
tests/app/notify_client/test_user_client.py
View File

@@ -141,7 +141,7 @@ def test_client_converts_admin_permissions_to_db_permissions_on_edit(app_, mocke
user_api_client.set_user_permissions('user_id', 'service_id', permissions={'send_messages', 'view_activity'}) user_api_client.set_user_permissions('user_id', 'service_id', permissions={'send_messages', 'view_activity'})
assert sorted(mock_post.call_args[1]['data'], key=lambda x: x['permission']) == sorted([ assert sorted(mock_post.call_args[1]['data']['permissions'], key=lambda x: x['permission']) == sorted([
{'permission': 'send_texts'}, {'permission': 'send_texts'},
{'permission': 'send_emails'}, {'permission': 'send_emails'},
{'permission': 'send_letters'}, {'permission': 'send_letters'},