darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-09 10:09:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

Added fixes for forms to hide potential email philshing scams.

Browse Source
This commit is contained in:
Nicholas Staples
2016-01-28 16:36:36 +00:00
parent d52a5553a9
commit 62150e5596
6 changed files with 53 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/app/main/test_validators.py
View File

@@ -3,7 +3,7 @@ from app.main.forms import RegisterUserForm
def test_should_raise_validation_error_for_password(app_, mock_get_user_by_email):
form = RegisterUserForm(users_dao.get_user_by_email)
form = RegisterUserForm()
form.name.data = 'test'
form.email_address.data = 'teset@example.gov.uk'
form.mobile_number.data = '+441231231231'

12
tests/app/main/views/test_sign_in.py
View File

@@ -42,8 +42,8 @@ def test_process_sign_in_return_2fa_template(app_,
url_for('main.sign_in'), data={
'email_address': 'valid@example.gov.uk',
'password': 'val1dPassw0rd!'})
assert response.status_code == 302
assert response.location == 'http://localhost/two-factor'
assert response.status_code == 302
assert response.location == url_for('.two_factor', _external=True)
mock_verify_password.assert_called_with(api_user_active.id, 'val1dPassw0rd!')
@@ -80,11 +80,13 @@ def test_should_return_200_when_user_does_not_exist(app_, mock_get_user_by_email
assert 'Username or password is incorrect' in response.get_data(as_text=True)
def test_should_return_200_when_user_is_pending(app_, mock_get_user_by_email_pending):
def test_should_return_redirect_when_user_is_pending(app_,
mock_get_user_by_email_pending,
mock_verify_password):
with app_.test_request_context():
response = app_.test_client().post(
url_for('main.sign_in'), data={
'email_address': 'pending_user@example.gov.uk',
'password': 'val1dPassw0rd!'})
assert response.status_code == 200
assert 'Username or password is incorrect' in response.get_data(as_text=True)
assert response.status_code == 302
assert response.location == url_for('main.verify', _external=True)