darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-02 17:48:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Validation on key name is case insenstive

Browse Source
This commit is contained in:
Rebecca Law
2016-01-21 16:52:01 +00:00
parent 81a5164fa5
commit 61893c5c7e
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/main/forms.py
View File

@@ -239,7 +239,7 @@ class ConfirmMobileNumberForm(Form):
class CreateKeyForm(Form): class CreateKeyForm(Form):
def __init__(self, existing_key_names=[], *args, **kwargs): def __init__(self, existing_key_names=[], *args, **kwargs):
self.existing_key_names = existing_key_names self.existing_key_names = [x.lower() for x in existing_key_names]
super(CreateKeyForm, self).__init__(*args, **kwargs) super(CreateKeyForm, self).__init__(*args, **kwargs)
key_name = StringField(u'Description of key', validators=[ key_name = StringField(u'Description of key', validators=[
@@ -247,5 +247,5 @@ class CreateKeyForm(Form):
]) ])
def validate_key_name(self, key_name): def validate_key_name(self, key_name):
if key_name.data in self.existing_key_names: if key_name.data.lower() in self.existing_key_names:
raise ValidationError('A key with this name already exists') raise ValidationError('A key with this name already exists')

2
tests/app/main/test_create_api_key_form.py
View File

@@ -11,6 +11,6 @@ def test_return_validation_error_when_key_name_exists(app_,
with app_.test_request_context(): with app_.test_request_context():
form = CreateKeyForm(_get_names(), form = CreateKeyForm(_get_names(),
formdata=MultiDict([('key_name', 'some key')])) formdata=MultiDict([('key_name', 'Some key')]))
form.validate() form.validate()
assert {'key_name': ['A key with this name already exists']} == form.errors assert {'key_name': ['A key with this name already exists']} == form.errors