darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-09 17:09:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

Split platform admin test out

Browse Source 
By making the one platform admin case a separate test we no longer
need to pass in a `user` or `kwargs` to the parametrize every time,
making it easier to read.
This commit is contained in:
Chris Hill-Scott
2022-06-06 11:45:10 +01:00
parent f79c3f27e3
commit 60870c69a7
1 changed files with 23 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
tests/app/utils/test_user.py
View File

@@ -4,7 +4,7 @@ from werkzeug.exceptions import Forbidden
from app.main.views.index import index from app.main.views.index import index
from app.utils.user import user_has_permissions from app.utils.user import user_has_permissions
from tests.conftest import create_platform_admin_user, create_user, sample_uuid from tests.conftest import create_user, sample_uuid
_user_with_permissions = create_user( _user_with_permissions = create_user(
id=sample_uuid(), id=sample_uuid(),
@@ -13,59 +13,43 @@ _user_with_permissions = create_user(
) )
@pytest.mark.parametrize('user, permissions, kwargs', ( @pytest.mark.parametrize('permissions', (
pytest.param( pytest.param(
_user_with_permissions,
['send_messages'], ['send_messages'],
{},
marks=pytest.mark.xfail(raises=Forbidden),
),
(
_user_with_permissions,
['manage_service'],
{},
),
(
_user_with_permissions,
['send_messages', 'manage_service'],
{},
),
(
_user_with_permissions,
['manage_templates', 'manage_service'],
{},
),
(
_user_with_permissions,
['manage_service', 'manage_templates'],
{},
),
(
_user_with_permissions,
[],
{},
),
pytest.param(
create_platform_admin_user(),
[],
{'restrict_admin_usage': True},
marks=pytest.mark.xfail(raises=Forbidden), marks=pytest.mark.xfail(raises=Forbidden),
), ),
['manage_service'],
['send_messages', 'manage_service'],
['manage_templates', 'manage_service'],
['manage_service', 'manage_templates'],
[],
)) ))
def test_permissions( def test_permissions(
client_request, client_request,
user,
permissions, permissions,
kwargs,
): ):
request.view_args.update({'service_id': 'foo'}) request.view_args.update({'service_id': 'foo'})
client_request.login(user) client_request.login(_user_with_permissions)
decorator = user_has_permissions(*permissions, **(kwargs or {})) decorator = user_has_permissions(*permissions)
decorated_index = decorator(index) decorated_index = decorator(index)
decorated_index() decorated_index()
def test_restrict_admin_usage(
client_request,
platform_admin_user,
):
request.view_args.update({'service_id': 'foo'})
client_request.login(platform_admin_user)
decorator = user_has_permissions(restrict_admin_usage=True)
decorated_index = decorator(index)
with pytest.raises(Forbidden):
decorated_index()
def test_no_user_returns_redirect_to_sign_in( def test_no_user_returns_redirect_to_sign_in(
client_request client_request
): ):