darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-18 05:29:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

Show user names for events without API changes

Browse Source 
This commit introduces a slightly hacky way of putting usernames against
events, given that the API only returns user IDs.

It does so without:
- making changes to the API
- making a pages that could potentially fire off dozens of API calls (ie
  one per user)

This comes with the limitation that it can only get names for those team
members who are still in the team. Otherwise it will say ‘Unknown’.

In the future the API should probably return the name and email address
for the user who initiated the event, and whether that user was acting
in a platform admin capacity.
This commit is contained in:
Chris Hill-Scott
2019-10-21 14:08:18 +01:00
parent 9055a33dca
commit 600e3affc1
5 changed files with 20 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/app/main/views/test_history.py
View File

@@ -8,30 +8,30 @@ from tests.conftest import SERVICE_ONE_ID, normalize_spaces
(
'12 December',
(
'6ce466d0-fd6a-11e5-82f5-e0accb9d11a6 12:12pm '
'Test User 12:12pm '
'Renamed this service from ‘Example service’ to ‘Real service’'
),
),
(
'11 November',
(
'6ce466d0-fd6a-11e5-82f5-e0accb9d11a6 12:12pm '
'Test User 12:12pm '
'Revoked the ‘Bad key’ API key'
),
),
(
'11 November',
(
'6ce466d0-fd6a-11e5-82f5-e0accb9d11a6 11:11am '
'Test User 11:11am '
'Created an API key called ‘Bad key’'
),
),
(
'10 October',
(
'6ce466d0-fd6a-11e5-82f5-e0accb9d11a6 11:10am '
'Test User 11:10am '
'Created an API key called ‘Good key’ '
'6ce466d0-fd6a-11e5-82f5-e0accb9d11a6 2:01am '
'Unknown 2:01am '
'Created this service and called it ‘Example service’'
),
),
@@ -40,21 +40,21 @@ from tests.conftest import SERVICE_ONE_ID, normalize_spaces
(
'11 November',
(
'6ce466d0-fd6a-11e5-82f5-e0accb9d11a6 12:12pm '
'Test User 12:12pm '
'Revoked the ‘Bad key’ API key'
),
),
(
'11 November',
(
'6ce466d0-fd6a-11e5-82f5-e0accb9d11a6 11:11am '
'Test User 11:11am '
'Created an API key called ‘Bad key’'
),
),
(
'10 October',
(
'6ce466d0-fd6a-11e5-82f5-e0accb9d11a6 11:10am '
'Test User 11:10am '
'Created an API key called ‘Good key’'
),
),
@@ -63,14 +63,14 @@ from tests.conftest import SERVICE_ONE_ID, normalize_spaces
(
'12 December',
(
'6ce466d0-fd6a-11e5-82f5-e0accb9d11a6 12:12pm '
'Test User 12:12pm '
'Renamed this service from ‘Example service’ to ‘Real service’'
),
),
(
'10 October',
(
'6ce466d0-fd6a-11e5-82f5-e0accb9d11a6 2:01am '
'Unknown 2:01am '
'Created this service and called it ‘Example service’'
),
),