From d7ac0fd12e7d5d145525eea79804d51bf633e5c2 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Wed, 10 Feb 2016 09:40:05 +0000 Subject: [PATCH 1/2] Mask phone number on jobs page MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The phone number on the job page is hard coded at the moment. This is not good for the demo, and showing it is probably not good because we don’t want to be storing it forever. So this commit: - masks it out with bullets • because they’re nicer than asteriks - adds a ‘row number’ column, which I think is good for users uploading CSVs to reconcile the job run with their data (if we’re not showing the data any more) --- app/templates/views/job.html | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/templates/views/job.html b/app/templates/views/job.html index 08fa08d5d..768519423 100644 --- a/app/templates/views/job.html +++ b/app/templates/views/job.html @@ -52,19 +52,23 @@ {% call(item) list_table( [ - {'phone': '+447700 900995', 'template': template['name'], 'status': 'queued'} + {'row': 1, 'phone': '+447700 900995', 'template': template['name'], 'status': 'queued'} ], caption=uploaded_file_name, caption_visible=False, empty_message="Messages go here", field_headings=[ + 'Row', 'Recipient', 'Template', right_aligned_field_heading('Status') ] ) %} {% call field() %} - {{item.phone}} + {{ item.row }}. + {% endcall %} + {% call field() %} + {{item.phone[:3]}} •••• •••••• {% endcall %} {% call field() %} {{item.template}} From fd052d566735cc34fb5d9d6d7bec97c7e133cbb7 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Wed, 10 Feb 2016 09:46:02 +0000 Subject: [PATCH 2/2] Make message sent, not queued, for realism --- app/templates/views/job.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/templates/views/job.html b/app/templates/views/job.html index 768519423..c72e6d34f 100644 --- a/app/templates/views/job.html +++ b/app/templates/views/job.html @@ -29,12 +29,12 @@