darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-08 08:28:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3076 from alphagov/upload-letters-service-setting

Browse Source 
Add upload letters permission to service settings page
This commit is contained in:
Katie Smith
2019-08-06 13:30:32 +01:00
committed by GitHub
parent 16da5d8243 0882c76476
commit 5e39163277
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/main/views/service_settings.py
View File

@@ -68,6 +68,7 @@ PLATFORM_ADMIN_SERVICE_PERMISSIONS = OrderedDict([
('inbound_sms', {'title': 'Receive inbound SMS', 'requires': 'sms', 'endpoint': '.service_set_inbound_number'}), ('inbound_sms', {'title': 'Receive inbound SMS', 'requires': 'sms', 'endpoint': '.service_set_inbound_number'}),
('email_auth', {'title': 'User auth type editing'}), ('email_auth', {'title': 'User auth type editing'}),
('upload_document', {'title': 'Uploading documents', 'endpoint': '.service_switch_can_upload_document'}), ('upload_document', {'title': 'Uploading documents', 'endpoint': '.service_switch_can_upload_document'}),
('upload_letters', {'title': 'Uploading letters', 'requires': 'letter'}),
]) ])

6
tests/app/main/views/service_settings/test_service_setting_permissions.py
View File

@@ -74,12 +74,14 @@ def test_service_set_permission(
({'permissions': []}, ({'permissions': []},
'.service_switch_can_upload_document', {}, 'Uploading documents Off Change'), '.service_switch_can_upload_document', {}, 'Uploading documents Off Change'),
({'permissions': ['sms']}, '.service_set_inbound_number', {}, 'Receive inbound SMS Off Change'), ({'permissions': ['sms']}, '.service_set_inbound_number', {}, 'Receive inbound SMS Off Change'),
({'permissions': ['letter']},
'.service_set_permission', {'permission': 'upload_letters'}, 'Uploading letters Off Change'),
]) ])
def test_service_setting_toggles_show(get_service_settings_page, service_one, service_fields, endpoint, kwargs, text): def test_service_setting_toggles_show(get_service_settings_page, service_one, service_fields, endpoint, kwargs, text):
button_url = url_for(endpoint, **kwargs, service_id=service_one['id']) link_url = url_for(endpoint, **kwargs, service_id=service_one['id'])
service_one.update(service_fields) service_one.update(service_fields)
page = get_service_settings_page() page = get_service_settings_page()
assert normalize_spaces(page.find('a', {'href': button_url}).find_parent('tr').text.strip()) == text assert normalize_spaces(page.find('a', {'href': link_url}).find_parent('tr').text.strip()) == text
@pytest.mark.parametrize('service_fields, endpoint, index, text', [ @pytest.mark.parametrize('service_fields, endpoint, index, text', [