darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-06 02:48:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix link in delivery status page

Browse Source
This commit is contained in:
Leo Hemsted
2021-10-20 11:39:05 +01:00
parent b8745e7b18
commit 5e36061df6
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/templates/views/message-status.html
View File

@@ -55,7 +55,7 @@
('Sending', 'Notify has sent the message to the provider. The provider will try to deliver the message to the recipient for up to 72 hours. Notify is waiting for delivery information.'), ('Sending', 'Notify has sent the message to the provider. The provider will try to deliver the message to the recipient for up to 72 hours. Notify is waiting for delivery information.'),
('Sent to an international number', 'The mobile networks in some countries do not provide any more delivery information.'), ('Sent to an international number', 'The mobile networks in some countries do not provide any more delivery information.'),
('Delivered', 'The message was successfully delivered. Notify will not tell you if a user has opened or read a message.'), ('Delivered', 'The message was successfully delivered. Notify will not tell you if a user has opened or read a message.'),
('Not delivered', 'The provider could not deliver the message. This can happen if the phone number was wrong or if the network operator rejects the message. If you’re sure that these phone numbers are correct, you should <a class="govuk-link govuk-link--no-visited-state" href="{{ url_for(".support") }}">contact us</a>. If not, you should remove them from your database. You’ll still be charged for text messages that cannot be delivered.'|safe), ('Not delivered', ('The provider could not deliver the message. This can happen if the phone number was wrong or if the network operator rejects the message. If you’re sure that these phone numbers are correct, you should <a class="govuk-link govuk-link--no-visited-state" href="' + url_for(".support") + '">contact us</a>. If not, you should remove them from your database. You’ll still be charged for text messages that cannot be delivered.')|safe),
('Phone not accepting messages right now', 'The provider could not deliver the message. This can happen when the recipient’s phone is off, has no signal, or their text message inbox is full. You can try to send the message again. You’ll still be charged for text messages to phones that are not accepting messages.'), ('Phone not accepting messages right now', 'The provider could not deliver the message. This can happen when the recipient’s phone is off, has no signal, or their text message inbox is full. You can try to send the message again. You’ll still be charged for text messages to phones that are not accepting messages.'),
('Technical failure', 'Your message was not sent because there was a problem between Notify and the provider. You’ll have to try sending your messages again. You will not be charged for text messages that are affected by a technical failure.'), ('Technical failure', 'Your message was not sent because there was a problem between Notify and the provider. You’ll have to try sending your messages again. You will not be charged for text messages that are affected by a technical failure.'),
] %} ] %}

8
tests/app/main/views/test_index.py
View File

@@ -188,6 +188,14 @@ def test_message_status_page_contains_message_status_ids(client_request):
assert page.find(id='sms-statuses') assert page.find(id='sms-statuses')
def test_message_status_page_contains_link_to_support(client_request):
page = client_request.get('main.message_status')
sms_status_table = page.find(id='sms-statuses').findNext('tbody')
temp_fail_details_cell = sms_status_table.select_one('tr:nth-child(4) > td:nth-child(2)')
assert temp_fail_details_cell.find('a').attrs['href'] == url_for('main.support')
def test_old_using_notify_page(client_request): def test_old_using_notify_page(client_request):
client_request.get('main.using_notify', _expected_status=410) client_request.get('main.using_notify', _expected_status=410)