darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-09 06:03:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove argument unpacking from get_areas

Browse Source 
Making it only callable in one way is just less stuff to understand.
This commit is contained in:
Chris Hill-Scott
2021-08-06 10:06:26 +01:00
parent 6c766c24b6
commit 5e1b96a3a7
4 changed files with 17 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
app/broadcast_areas/models.py
View File

@@ -227,18 +227,11 @@ class BroadcastAreaLibraries(SerialisedModelCollection, GetItemByIdMixin):
def __init__(self):
self.items = BroadcastAreasRepository().get_libraries()
def get_areas(self, *area_ids):
# allow people to call `get_areas('a', 'b') or get_areas(['a', 'b'])`
if len(area_ids) == 1 and isinstance(area_ids[0], list):
area_ids = area_ids[0]
def get_areas(self, area_ids):
areas = BroadcastAreasRepository().get_areas(area_ids)
return [BroadcastArea(area) for area in areas]
def get_areas_with_simple_polygons(self, *area_ids):
if len(area_ids) == 1 and isinstance(area_ids[0], list):
area_ids = area_ids[0]
def get_areas_with_simple_polygons(self, area_ids):
areas = BroadcastAreasRepository().get_areas_with_simple_polygons(area_ids)
return [BroadcastArea.from_row_with_simple_polygons(area) for area in areas]