darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-20 14:29:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2954 from alphagov/support-welsh-characters

Browse Source 
Allow Welsh characters in SMS templates
This commit is contained in:
Katie Smith
2019-05-15 16:34:02 +01:00
committed by GitHub
parent 61b056e490 be71aec24f
commit 5df3148610
7 changed files with 40 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/app/main/test_validators.py
View File

@@ -6,7 +6,7 @@ from wtforms import ValidationError
from app.main.forms import RegisterUserForm, ServiceSmsSenderForm
from app.main.validators import (
NoCommasInPlaceHolders,
OnlyGSMCharacters,
OnlySMSCharacters,
ValidGovEmail,
)
@@ -165,8 +165,8 @@ def test_for_commas_in_placeholders(
@pytest.mark.parametrize('msg', ['The quick brown fox', 'Thé “quick” bröwn fox\u200B'])
def test_gsm_character_validation(client, msg):
OnlyGSMCharacters()(None, _gen_mock_field(msg))
def test_sms_character_validation(client, msg):
OnlySMSCharacters()(None, _gen_mock_field(msg))
@pytest.mark.parametrize('data, err_msg', [
@@ -185,9 +185,9 @@ def test_gsm_character_validation(client, msg):
)
),
])
def test_non_gsm_character_validation(data, err_msg, client):
def test_non_sms_character_validation(data, err_msg, client):
with pytest.raises(ValidationError) as error:
OnlyGSMCharacters()(None, _gen_mock_field(data))
OnlySMSCharacters()(None, _gen_mock_field(data))
assert str(error.value) == err_msg