From 5c62a14b2d6167323075ae1be61ff83e531c6094 Mon Sep 17 00:00:00 2001 From: Adam Shimali Date: Mon, 4 Jul 2016 14:53:34 +0100 Subject: [PATCH] Parameterize test --- tests/app/main/views/test_service_settings.py | 24 +++++++------------ 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/tests/app/main/views/test_service_settings.py b/tests/app/main/views/test_service_settings.py index a76ead847..8381cfa41 100644 --- a/tests/app/main/views/test_service_settings.py +++ b/tests/app/main/views/test_service_settings.py @@ -737,16 +737,22 @@ def test_if_sms_sender_set_then_form_populated(app_, assert page.find(id='sms_sender')['value'] == 'elevenchars' +@pytest.mark.parametrize("sender, expected_flash_message", [ + ("elevenchars", 'Text message sender set to elevenchars'), + ('', 'Text message sender removed') +]) def test_set_text_message_sender_flash_messages( app_, active_user_with_permissions, mocker, mock_update_service, - service_one): + service_one, + sender, + expected_flash_message): with app_.test_request_context(): with app_.test_client() as client: client.login(active_user_with_permissions, mocker, service_one) - data = {"sms_sender": "elevenchars"} + data = {"sms_sender": sender} response = client.post(url_for('main.service_set_sms_sender', service_id=service_one['id']), data=data, follow_redirects=True) @@ -756,16 +762,4 @@ def test_set_text_message_sender_flash_messages( page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser') element = page.find('div', {"class": "banner-default-with-tick"}) - assert element.text.strip() == 'Text message sender set to elevenchars' - - data = {"sms_sender": ""} - response = client.post(url_for('main.service_set_sms_sender', service_id=service_one['id']), - data=data, - follow_redirects=True) - - assert response.status_code == 200 - - page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser') - element = page.find('div', {"class": "banner-default-with-tick"}) - - assert element.text.strip() == 'Text message sender removed' + assert element.text.strip() == expected_flash_message