darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-21 00:23:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

Migrate two more tests to the branding utility

Browse Source 
All of the mock / UI assertions in these tests are covered by the
tests above them - these tests were mostly targetting which options
were being shown, which we can check at a lower level.
This commit is contained in:
Ben Thorner
2022-03-03 12:58:44 +00:00
parent 1946d3c928
commit 5a39e310aa
2 changed files with 57 additions and 111 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
tests/app/utils/test_branding.py
View File

@@ -2,6 +2,7 @@ import pytest
from app.models.service import Service
from app.utils.branding import get_available_choices
from tests import organisation_json
@pytest.mark.parametrize('branding_type', ['email', 'letter'])
@@ -26,3 +27,59 @@ def test_get_available_choices_no_org(
options = get_available_choices(service, branding_type=branding_type)
assert list(options) == expected_options
@pytest.mark.parametrize('branding_type', ['email', 'letter'])
@pytest.mark.parametrize('org_type, existing_branding, expected_options', [
('local', None, [('organisation', 'Test Organisation')]),
('nhs_central', None, [('nhs', 'NHS')]),
('nhs_local', None, [('nhs', 'NHS')]),
('nhs_gp', None, [('nhs', 'NHS')]),
('emergency_service', None, [('organisation', 'Test Organisation')]),
('other', None, [('organisation', 'Test Organisation')]),
])
def test_get_available_choices_with_org(
mocker,
service_one,
branding_type,
org_type,
existing_branding,
expected_options,
mock_get_service_organisation,
):
service = Service(service_one)
mocker.patch(
'app.organisations_client.get_organisation',
return_value=organisation_json(organisation_type=org_type)
)
options = get_available_choices(service, branding_type=branding_type)
assert list(options) == expected_options
@pytest.mark.parametrize('branding_type, expected_options', [
('email', [
('govuk_and_org', 'GOV.UK and Test Organisation'),
('organisation', 'Test Organisation'),
]),
('letter', [
('organisation', 'Test Organisation'),
])
])
def test_get_available_choices_with_central_org(
mocker,
service_one,
branding_type,
expected_options,
mock_get_service_organisation,
):
service = Service(service_one)
mocker.patch(
'app.organisations_client.get_organisation',
return_value=organisation_json(organisation_type='central'),
)
options = get_available_choices(service, branding_type=branding_type)
assert list(options) == expected_options