darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-05 21:18:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix off-by-one dates on provider history

Browse Source 
We chunk history entries by their YYYY-MM-DD date representation to
display them day-by-day.

However trying to convert a YYYY-MM-DD string into a timestamp is
unpredictable, and was causing our dates to be one day out (probably
because of midnight/daylight savings/general datetime horrors).

This commit changes the code to do the same thing as the history page,
which is look at the `updated_at` field on the first entry to get a
datetime object and from that the formatted date we show in the headings
on the page.
This commit is contained in:
Chris Hill-Scott
2019-12-13 12:24:19 +00:00
parent 1e233f1167
commit 581296b95e
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/templates/views/providers/edit-sms-provider-ratio.html
View File

@@ -51,7 +51,7 @@
{% for day, versions in versions %} {% for day, versions in versions %}
<h2 class="heading-small top-gutter"> <h2 class="heading-small top-gutter">
{% if day %} {% if day %}
{{ day|format_date_human|title }} {{ versions[0]['updated_at']|format_date_human|title }}
{% else %} {% else %}
Start Start
{% endif %} {% endif %}

6
tests/app/main/views/test_providers.py
View File

@@ -6,6 +6,7 @@ from unittest.mock import call
import pytest import pytest
from bs4 import BeautifulSoup from bs4 import BeautifulSoup
from flask import url_for from flask import url_for
from freezegun import freeze_time
import app import app
from app.main.views.providers import add_monthly_traffic from app.main.views.providers import add_monthly_traffic
@@ -409,6 +410,7 @@ def test_should_show_provider_version_history(
assert second_row[4].text.strip() == "True" assert second_row[4].text.strip() == "True"
@freeze_time('2022-2-22 15:00')
def test_should_show_version_history_for_first_two_sms_providers( def test_should_show_version_history_for_first_two_sms_providers(
client_request, client_request,
platform_admin_user, platform_admin_user,
@@ -473,8 +475,8 @@ def test_should_show_version_history_for_first_two_sms_providers(
for heading in page.select('main h2') for heading in page.select('main h2')
] == [ ] == [
'Now', 'Now',
'21 February 2022', 'Today',
'31 December', '1 January 2020',
] ]
assert [ assert [