darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-18 21:49:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3690 from alphagov/set-message-limit

Browse Source 
Remove the `upload_letters` permission
This commit is contained in:
Chris Hill-Scott
2020-10-23 12:27:28 +01:00
committed by GitHub
parent 7231f8a168 7424cb37a3
commit 57fc209f44
6 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/main/views/service_settings.py
View File

@@ -68,7 +68,6 @@ from app.utils import (
PLATFORM_ADMIN_SERVICE_PERMISSIONS = OrderedDict([
('inbound_sms', {'title': 'Receive inbound SMS', 'requires': 'sms', 'endpoint': '.service_set_inbound_number'}),
('email_auth', {'title': 'Email authentication'}),
('upload_letters', {'title': 'Uploading letters', 'requires': 'letter'}),
('international_letters', {'title': 'Send international letters', 'requires': 'letter'}),
('broadcast', {'title': 'Send cell broadcasts'}),
])

2
app/main/views/uploads.py
View File

@@ -341,7 +341,7 @@ def view_letter_upload_as_preview(service_id, file_id):
@main.route("/services/<uuid:service_id>/upload-letter/send/<uuid:file_id>", methods=['POST'])
@user_has_permissions('send_messages', restrict_admin_usage=True)
def send_uploaded_letter(service_id, file_id):
if not (current_service.has_permission('letter') and current_service.has_permission('upload_letters')):
if not current_service.has_permission('letter'):
abort(403)
metadata = get_letter_metadata(service_id, file_id)