darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-17 04:59:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Validate against empty form submission for find_users_by_email

Browse Source 
This included:
- creating a new form SearchUsersByEmailForm with validation
on its search field

- introducing 400 status to the view  if the form does not validate

- fixing the POST request data structure in the tests (it was
incorrect before and uncaught due to lack of validation and mocking
the response from the API.
This commit is contained in:
Pea Tyczynska
2018-07-10 16:33:13 +01:00
parent d1a05e2ec5
commit 57e9c1d6e6
3 changed files with 31 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tests/app/main/views/test_find_users.py
View File

@@ -30,7 +30,7 @@ def test_find_users_by_email_displays_users_found(
mock_get_user(mocker, user=platform_admin_user)
client.login(platform_admin_user)
mocker.patch('app.user_api_client.find_users_by_full_or_partial_email', return_value={"data": [user_json()]}, autospec=True)
response = client.post(url_for('main.find_users_by_email', data=[{"email": "twilight.sparkle"}]))
response = client.post(url_for('main.find_users_by_email'), data={"search": "twilight.sparkle"})
assert response.status_code == 200
document = html.fromstring(response.get_data(as_text=True))
@@ -44,8 +44,22 @@ def test_find_users_by_email_displays_message_if_no_users_found(
mock_get_user(mocker, user=platform_admin_user)
client.login(platform_admin_user)
mocker.patch('app.user_api_client.find_users_by_full_or_partial_email', return_value={"data": []}, autospec=True)
response = client.post(url_for('main.find_users_by_email', data=[{"email": "twilight.sparkle"}]))
response = client.post(url_for('main.find_users_by_email'), data={"search": "twilight.sparkle"})
assert response.status_code == 200
document = html.fromstring(response.get_data(as_text=True))
assert "No users found." in document.text_content()
def test_find_users_by_email_validates_against_empty_search_submission(
client,
platform_admin_user,
mocker
):
mock_get_user(mocker, user=platform_admin_user)
client.login(platform_admin_user)
response = client.post(url_for('main.find_users_by_email'), data={"search": ""})
assert response.status_code == 400
document = html.fromstring(response.get_data(as_text=True))
assert "You need to enter full or partial e-mail address to search by." in document.text_content()