diff --git a/app/assets/stylesheets/govuk-frontend/overrides.scss b/app/assets/stylesheets/govuk-frontend/overrides.scss index 4269c4181..5fc2cfa4c 100644 --- a/app/assets/stylesheets/govuk-frontend/overrides.scss +++ b/app/assets/stylesheets/govuk-frontend/overrides.scss @@ -1,16 +1,5 @@ // Overrides for certain GOV.UK Frontend styles to make its components match this application's design -// Notify's header navigation aligns to the right -.govuk-header__navigation { - text-align: right; - - // reset the alignment of each item to left-to-right - .govuk-header__navigation-item { - text-align: left; - } - -} - // Additional padding-bottom override, following the GOV.UK Frontend spacing scale: // https://design-system.service.gov.uk/styles/spacing/#the-responsive-spacing-scale .govuk-\!-padding-bottom-12 { @@ -48,3 +37,8 @@ } } + +// Make column headings smaller to prevent wrapping +.govuk-footer__heading { + @include govuk-font($size: 19, $weight: bold); +} diff --git a/app/templates/admin_template.html b/app/templates/admin_template.html index 4d705ad73..feefab8da 100644 --- a/app/templates/admin_template.html +++ b/app/templates/admin_template.html @@ -1,6 +1,5 @@ {% extends "template.njk" %} {% from "components/banner.html" import banner %} -{% from "components/notify-footer.html" import notify_footer %} {% block headIcons %} @@ -125,7 +124,8 @@ {{ govukHeader({ "homepageUrl": url_for('main.show_accounts_or_dashboard'), "productName": "Notify", - "navigation": navigation + "navigation": navigation, + "navigationClasses": "govuk-header__navigation--end" }) }} {% endblock %} @@ -147,35 +147,29 @@ {% set meta_suffix = 'Built by the Government Digital Service' %} {% endif %} - {{ notify_footer({ + {{ govukFooter({ "classes": "js-footer", "navigation": [ { + "title": "Support", "columns": 1, "items": [ { "href": url_for('main.support'), - "text": "Support" + "text": "Contact support" }, { "href": "https://status.notifications.service.gov.uk", "text": "System status" }, - { - "href": "https://www.gov.uk/performance/govuk-notify", - "text": "Performance" - }, { "href": "https://ukgovernmentdigital.slack.com/messages/C0E1ADVPC", - "text": "Slack channel" - }, - { - "href": "https://gds.blog.gov.uk/category/notify/", - "text": "Blog" + "text": "Chat to us on Slack" } ] }, { + "title": "About Notify", "columns": 1, "items": [ { @@ -186,14 +180,6 @@ "href": url_for("main.roadmap"), "text": "Roadmap" }, - { - "href": url_for("main.trial_mode_new"), - "text": "Trial mode" - }, - { - "href": url_for("main.message_status"), - "text": "Message status" - }, { "href": url_for("main.security"), "text": "Security" @@ -201,10 +187,19 @@ { "href": url_for("main.terms"), "text": "Terms of use" + }, + { + "href": "https://www.gov.uk/performance/govuk-notify", + "text": "Performance" + }, + { + "href": "https://gds.blog.gov.uk/category/notify/", + "text": "Blog" } ] }, { + "title": "Pricing and payment", "columns": 1, "items": [ { @@ -218,11 +213,24 @@ ] }, { + "title": "Using Notify", "columns": 1, "items": [ + { + "href": url_for("main.get_started"), + "text": "Get started" + }, + { + "href": url_for("main.trial_mode_new"), + "text": "Trial mode" + }, + { + "href": url_for("main.message_status"), + "text": "Message status" + }, { "href": url_for("main.documentation"), - "text": "Documentation" + "text": "API documentation" } ] } diff --git a/app/templates/components/notify-footer.html b/app/templates/components/notify-footer.html deleted file mode 100644 index ccb8f2301..000000000 --- a/app/templates/components/notify-footer.html +++ /dev/null @@ -1,90 +0,0 @@ -{% macro notify_footer(params) %} - - - -{% endmacro %} diff --git a/tests/app/main/views/test_dashboard.py b/tests/app/main/views/test_dashboard.py index 65131cc6d..7d0ebc05c 100644 --- a/tests/app/main/views/test_dashboard.py +++ b/tests/app/main/views/test_dashboard.py @@ -181,7 +181,7 @@ def test_get_started_is_hidden_once_templates_exist( ) mock_get_service_templates.assert_called_once_with(SERVICE_ONE_ID) - assert 'Get started' not in page.text + assert not page.find('h2', string='Get started') def test_inbound_messages_not_visible_to_service_without_permissions(