separate get_job and get_jobs in job_api_client

also remove the status parameter, as we never use it anywhere
This commit is contained in:
Leo Hemsted
2016-09-22 09:53:33 +01:00
parent 5bb700ac81
commit 549a17c1f7
6 changed files with 16 additions and 51 deletions

View File

@@ -26,21 +26,19 @@ class JobApiClient(BaseAPIClient):
results['requested'] += outcome['count']
return results
def get_job(self, service_id, job_id=None, limit_days=None, status=None):
if job_id:
params = {}
if status is not None:
params['status'] = status
job = self.get(url='/service/{}/job/{}'.format(service_id, job_id), params=params)
def get_job(self, service_id, job_id):
params = {}
job = self.get(url='/service/{}/job/{}'.format(service_id, job_id), params=params)
stats = self.__convert_statistics(job['data'])
job['data']['notifications_sent'] = stats['delivered'] + stats['failed']
job['data']['notifications_delivered'] = stats['delivered']
job['data']['notifications_failed'] = stats['failed']
job['data']['notifications_requested'] = stats['requested']
stats = self.__convert_statistics(job['data'])
job['data']['notifications_sent'] = stats['delivered'] + stats['failed']
job['data']['notifications_delivered'] = stats['delivered']
job['data']['notifications_failed'] = stats['failed']
job['data']['notifications_requested'] = stats['requested']
return job
return job
def get_jobs(self, service_id, limit_days=None):
params = {}
if limit_days is not None:
params['limit_days'] = limit_days