darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-20 14:29:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

make inbound search a POST

Browse Source 
that way it doesn't expose PII to our logs
This commit is contained in:
Leo Hemsted
2019-03-29 15:16:29 +00:00
parent c5208d712e
commit 53cdbad2cc
3 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/notify_client/notification_api_client.py
View File

@@ -19,7 +19,7 @@ class NotificationApiClient(NotifyAdminAPIClient):
to=None,
include_one_off=None,
):
# TODO: if "to" is included, this should be a POST
params = {
'page': page,
'page_size': page_size,

10
app/notify_client/service_api_client.py
View File

@@ -291,15 +291,13 @@ class ServiceAPIClient(NotifyAdminAPIClient):
def update_whitelist(self, service_id, data):
return self.put(url='/service/{}/whitelist'.format(service_id), data=data)
def get_inbound_sms(self, service_id, user_number='', page=None):
return self.get(
def get_inbound_sms(self, service_id, user_number=''):
# POST prevents the user phone number leaking into our logs
return self.post(
'/service/{}/inbound-sms'.format(
service_id,
),
params={
'user_number': user_number,
'page': page
}
data={'user_number': user_number}
)
def get_most_recent_inbound_sms(self, service_id, page=None):