darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-07 09:18:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary logic/fix tests

Browse Source
This commit is contained in:
Andrew Shumway
2023-11-22 11:06:15 -07:00
parent 450be48e9c
commit 53a3f4c852
2 changed files with 4 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/main/views/send.py
View File

@@ -275,19 +275,11 @@ def remove_notify_from_sender_options(sender_details):
def verify_sender_options(sender): def verify_sender_options(sender):
if sender.get("sms_sender") in ["Notify.gov", "US Notify"] and sender["is_default"]: if sender.get("sms_sender") not in ["Notify.gov", "US Notify"]:
return True
if (
sender.get("sms_sender") not in ["Notify.gov", "US Notify"]
and not sender["is_default"]
):
return True
if (
sender.get("sms_sender") not in ["Notify.gov", "US Notify"]
and sender["is_default"]
):
return True return True
return False
def get_sender_context(sender_details, template_type): def get_sender_context(sender_details, template_type):
context = { context = {

2
tests/app/main/views/test_send.py
View File

@@ -308,7 +308,7 @@ def test_usnotify_and_notifygov_sms_sender_removal_if_default(sender_data, mocke
sender_details = remove_notify_from_sender_options(sender_data) sender_details = remove_notify_from_sender_options(sender_data)
assert len(sender_details) == 3 assert len(sender_details) == 2
def test_that_test_files_exist(): def test_that_test_files_exist():