darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-18 13:39:57 -04:00
Code Issues Packages Projects Releases Wiki Activity

Make developer instructions more explicit

Browse Source 
The previous ‘you need to update your API calls’ text isn’t clear enough
now that the context of the spreadsheet has been removed.
This commit is contained in:
Chris Hill-Scott
2019-11-20 12:01:26 +00:00
parent 4c6822b037
commit 534be751dd
3 changed files with 47 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/templates/components/list.html
View File

@@ -5,3 +5,11 @@
separator=' '
) }}
{%- endmacro %}
{% macro list_of_code_snippets(variables) %}
{{ variables | formatted_list(
before_each="<code>",
after_each='</code>',
separator=' '
) }}
{%- endmacro %}

31
app/templates/views/templates/breaking-change.html
View File

@@ -2,7 +2,7 @@
{% from "components/banner.html" import banner_wrapper %}
{% from "components/page-header.html" import page_header %}
{% from "components/page-footer.html" import page_footer %}
{% from "components/list.html" import list_of_placeholders %}
{% from "components/list.html" import list_of_placeholders, list_of_code_snippets %}
{% from "components/form.html" import form_wrapper %}
{% block service_page_title %}
@@ -15,20 +15,21 @@
'Confirm changes',
back_link=url_for(".edit_service_template", service_id=current_service.id, template_id=new_template.id)
) }}
{% if template_change.placeholders_removed %}
<p>
You removed {{ list_of_placeholders(template_change.placeholders_removed) }}
</p>
{% endif %}
{% if template_change.placeholders_added %}
<p>
You added {{ list_of_placeholders(template_change.placeholders_added) }}
</p>
{% endif %}
<p>
Developers, you’ll need to update your API calls.
</p>
<div class="grid-row">
<div class="column-five-sixths">
{% if template_change.placeholders_removed %}
<p>
You removed {{ list_of_placeholders(template_change.placeholders_removed) }}
</p>
{% endif %}
<p>
You added {{ list_of_placeholders(template_change.placeholders_added) }}
</p>
<p>
Before you send any messages, make sure your API calls include {{ list_of_code_snippets(template_change.placeholders_added) }}.
</p>
</div>
</div>
{% call form_wrapper() %}
<input type="hidden" name="name" value="{{ new_template.name }}" />