diff --git a/app/models/service.py b/app/models/service.py index 52ed19f90..c789dca8b 100644 --- a/app/models/service.py +++ b/app/models/service.py @@ -269,7 +269,7 @@ class Service(): @property def needs_to_change_sms_sender(self): return all(( - self.has_sms_templates, + self.volume_sms, self.shouldnt_use_govuk_as_sms_sender, self.sms_sender_is_govuk, )) diff --git a/tests/app/main/views/test_service_settings.py b/tests/app/main/views/test_service_settings.py index e58d7b9ac..747a8b884 100644 --- a/tests/app/main/views/test_service_settings.py +++ b/tests/app/main/views/test_service_settings.py @@ -1176,7 +1176,7 @@ def test_should_redirect_after_request_to_go_live( False, True, True, - 1, 1, 1, + 1, 0, 1, 'No', True, [ @@ -1228,7 +1228,7 @@ def test_should_redirect_after_request_to_go_live( True, True, False, - 1, 1, 1, + 1, 0, 0, 'No', True, [ @@ -1275,7 +1275,6 @@ def test_should_redirect_after_request_to_go_live( 'notify_request_to_go_live_incomplete_mou', 'notify_request_to_go_live_incomplete_team_member', 'notify_request_to_go_live_incomplete_template_content', - 'notify_request_to_go_live_incomplete_sms_sender', ], ), ),