darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-19 14:09:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2300 from alphagov/submit-returned-letters

Browse Source 
Add a platform admin page to submit returned letter references
This commit is contained in:
Alexey Bezhan
2018-09-07 15:06:24 +01:00
committed by GitHub
parent a9eb1c41d3 b75681dfbc
commit 5198009550
11 changed files with 124 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/main/views/test_activity.py
View File

@@ -32,7 +32,7 @@ from tests.conftest import (
'',
[
'created', 'pending', 'sending', 'pending-virus-check',
'delivered', 'sent',
'delivered', 'sent', 'returned-letter',
'failed', 'temporary-failure', 'permanent-failure', 'technical-failure', 'virus-scan-failed',
]
),
@@ -42,7 +42,7 @@ from tests.conftest import (
),
(
'delivered',
['delivered', 'sent']
['delivered', 'sent', 'returned-letter']
),
(
'failed',

5
tests/app/main/views/test_jobs.py
View File

@@ -155,7 +155,7 @@ def test_jobs_page_doesnt_show_scheduled_on_page_2(
'',
[
'created', 'pending', 'sending', 'pending-virus-check',
'delivered', 'sent',
'delivered', 'sent', 'returned-letter',
'failed', 'temporary-failure', 'permanent-failure', 'technical-failure', 'virus-scan-failed',
]
),
@@ -165,7 +165,7 @@ def test_jobs_page_doesnt_show_scheduled_on_page_2(
),
(
'delivered',
['delivered', 'sent']
['delivered', 'sent', 'returned-letter']
),
(
'failed',
@@ -306,6 +306,7 @@ def test_should_show_letter_job(
'pending-virus-check',
'delivered',
'sent',
'returned-letter',
'failed',
'temporary-failure',
'permanent-failure',

34
tests/app/main/views/test_platform_admin.py
View File

@@ -724,3 +724,37 @@ def test_platform_admin_displays_stats_in_right_boxes_and_with_correct_styling(
# Letter virus scan failure status box - number is correct and failure class is used
assert '1 virus scan failures' in page.find_all('div', class_='column-third')[2].find(
'div', class_='big-number-status-failing').text
def test_platform_admin_submit_returned_letters(mocker, client, platform_admin_user):
mock_get_user(mocker, user=platform_admin_user)
client.login(platform_admin_user)
mock_client = mocker.patch('app.letter_jobs_client.submit_returned_letters')
response = client.post(
url_for('main.platform_admin_returned_letters'),
data={'references': ' NOTIFY000REF1 \n NOTIFY002REF2 '}
)
mock_client.assert_called_once_with(['REF1', 'REF2'])
assert response.status_code == 302
assert response.location == url_for('main.platform_admin_returned_letters', _external=True)
def test_platform_admin_submit_empty_returned_letters(mocker, client, platform_admin_user):
mock_get_user(mocker, user=platform_admin_user)
client.login(platform_admin_user)
mock_client = mocker.patch('app.letter_jobs_client.submit_returned_letters')
response = client.post(
url_for('main.platform_admin_returned_letters'),
data={'references': ' \n '}
)
assert not mock_client.called
assert response.status_code == 200
assert "Can’t be empty" in response.get_data(as_text=True)