darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-25 00:33:58 -04:00
Code Issues Packages Projects Releases Wiki Activity

Convert radios on set-template-sender page

Browse Source 
Includes making the legend the h1 for the page to
follow design system guidance:

https://design-system.service.gov.uk/get-started/labels-legends-headings/
This commit is contained in:
Tom Byers
2021-01-13 14:58:39 +00:00
parent ece956e324
commit 513fbff6e0
5 changed files with 31 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/main/forms.py
View File

@@ -2021,7 +2021,7 @@ class SetTemplateSenderForm(StripWhitespaceForm):
self.sender.choices = kwargs['sender_choices']
self.sender.label.text = 'Select your sender'
sender = RadioField()
sender = GovukRadiosField()
class LinkOrganisationsForm(StripWhitespaceForm):

12
app/main/views/templates.py
View File

@@ -829,7 +829,14 @@ def set_template_sender(service_id, template_id):
sender=sender_details['current_choice'],
sender_choices=sender_details['value_and_label'],
)
option_hints = {sender_details['default_sender']: '(Default)'}
form.sender.param_extensions = {'items': []}
for item_value, _item_label in sender_details['value_and_label']:
if item_value == sender_details['default_sender']:
extensions = {'hint': {'text': '(Default)'}}
else:
extensions = {} # if no extensions needed, send an empty dict to preserve order of items
form.sender.param_extensions['items'].append(extensions)
if form.validate_on_submit():
service_api_client.update_service_template_sender(
@@ -843,8 +850,7 @@ def set_template_sender(service_id, template_id):
'views/templates/set-template-sender.html',
form=form,
template_id=template_id,
no_senders=no_senders,
option_hints=option_hints
no_senders=no_senders
)