From 50e3560c6ff6c4835fd1a8dae218f5f1286d4fa6 Mon Sep 17 00:00:00 2001
From: Carlo Costino <carlo.costino@gsa.gov>
Date: Tue, 30 Jan 2024 11:06:13 -0500
Subject: [PATCH] Remove the profile attribute entirely

This was what was apparently breaking our Terraform actions.  I traced this to an undocumented breaking change with the AWS provider; more details can be seen here: https://discuss.hashicorp.com/t/error-error-configuring-terraform-aws-provider-failed-to-get-shared-config-profile-default/39417/2

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
---
 terraform/README.md               | 2 ++
 terraform/demo/providers.tf       | 1 -
 terraform/development/reset.sh    | 2 +-
 terraform/production/providers.tf | 1 -
 terraform/sandbox/providers.tf    | 1 -
 terraform/staging/providers.tf    | 1 -
 6 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/terraform/README.md b/terraform/README.md
index efab933fa..7390e3947 100644
--- a/terraform/README.md
+++ b/terraform/README.md
@@ -88,6 +88,8 @@ The below steps rely on you first configuring access to the Terraform state in s
     terraform plan
     ```
 
+    If the `terraform init` command fails, you may need to run `terraform init -upgrade` to make sure new module versions are picked up.
+
 1. Apply changes with `terraform apply`.
 
 1. Remove the space deployer service instance if it doesn't need to be used again, such as when manually running terraform once.
diff --git a/terraform/demo/providers.tf b/terraform/demo/providers.tf
index 46ec2f376..2ced7915f 100644
--- a/terraform/demo/providers.tf
+++ b/terraform/demo/providers.tf
@@ -12,7 +12,6 @@ terraform {
     key     = "admin.tfstate.demo"
     encrypt = "true"
     region  = "us-gov-west-1"
-    profile = "notify-terraform-backend"
   }
 }
 
diff --git a/terraform/development/reset.sh b/terraform/development/reset.sh
index d51d43eec..57c2f4d87 100755
--- a/terraform/development/reset.sh
+++ b/terraform/development/reset.sh
@@ -47,7 +47,7 @@ if [[ ! -s "secrets.auto.tfvars" ]]; then
 fi
 
 echo "Importing terraform state for $username"
-terraform init
+terraform init -upgrade
 
 key_name=$username-admin-dev-key
 
diff --git a/terraform/production/providers.tf b/terraform/production/providers.tf
index 9805aaf87..ed822db44 100644
--- a/terraform/production/providers.tf
+++ b/terraform/production/providers.tf
@@ -12,7 +12,6 @@ terraform {
     key     = "admin.tfstate.prod"
     encrypt = "true"
     region  = "us-gov-west-1"
-    profile = "notify-terraform-backend"
   }
 }
 
diff --git a/terraform/sandbox/providers.tf b/terraform/sandbox/providers.tf
index d24d5a326..09911edc4 100644
--- a/terraform/sandbox/providers.tf
+++ b/terraform/sandbox/providers.tf
@@ -12,7 +12,6 @@ terraform {
     key     = "admin.tfstate.sandbox"
     encrypt = "true"
     region  = "us-gov-west-1"
-    profile = "notify-terraform-backend"
   }
 }
 
diff --git a/terraform/staging/providers.tf b/terraform/staging/providers.tf
index a6f8f2a54..d6928e61e 100644
--- a/terraform/staging/providers.tf
+++ b/terraform/staging/providers.tf
@@ -12,7 +12,6 @@ terraform {
     key     = "admin.tfstate.stage"
     encrypt = "true"
     region  = "us-gov-west-1"
-    profile = "notify-terraform-backend"
   }
 }