darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-08 22:43:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Test mock_update_service_template called with right args

Browse Source
This commit is contained in:
Pea Tyczynska
2018-12-21 15:51:24 +00:00
parent bc1e0b7167
commit 50935e79ca
2 changed files with 43 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/main/views/templates.py
View File

@@ -565,7 +565,6 @@ def edit_service_template(service_id, template_id):
template = service_api_client.get_service_template(service_id, template_id)['data'] template = service_api_client.get_service_template(service_id, template_id)['data']
template['template_content'] = template['content'] template['template_content'] = template['content']
form = form_objects[template['template_type']](**template) form = form_objects[template['template_type']](**template)
if form.validate_on_submit(): if form.validate_on_submit():
if form.process_type.data != template['process_type']: if form.process_type.data != template['process_type']:
abort_403_if_not_admin_user() abort_403_if_not_admin_user()

45
tests/app/main/views/test_templates.py
View File

@@ -1,8 +1,8 @@
import re
from datetime import datetime from datetime import datetime
from unittest.mock import ANY, Mock from unittest.mock import ANY, Mock
import pytest import pytest
import re
from bs4 import BeautifulSoup from bs4 import BeautifulSoup
from flask import url_for from flask import url_for
from freezegun import freeze_time from freezegun import freeze_time
@@ -13,7 +13,6 @@ from app.main.views.templates import (
get_last_use_message, get_last_use_message,
) )
from tests import ( from tests import (
service_json,
single_notification_json, single_notification_json,
template_json, template_json,
validate_route_permission, validate_route_permission,
@@ -482,6 +481,48 @@ def test_edit_letter_templates_postage_choice_visibility_and_default(
assert page.select('input[checked]')[0].attrs["value"] == 'None' assert page.select('input[checked]')[0].attrs["value"] == 'None'
@pytest.mark.parametrize("permissions, expected_result", [
(["choose_postage", "letter"], "first"),
(["letter"], None),
])
def test_edit_letter_templates_postage_permissions(
logged_in_client,
service_one,
mocker,
fake_uuid,
mock_update_service_template,
permissions,
expected_result
):
service_one['permissions'] = permissions
mock_get_service_letter_template(mocker)
template_id = fake_uuid
logged_in_client.post(
url_for(
'main.edit_service_template',
service_id=SERVICE_ONE_ID,
template_id=template_id
),
data={
'name': 'Two week reminder',
'template_content': "Some content",
'subject': 'Subject',
'postage': 'first'
}
)
mock_update_service_template.assert_called_with(
template_id,
'Two week reminder',
'letter',
"Some content",
SERVICE_ONE_ID,
'Subject',
'normal',
postage=expected_result
)
@pytest.mark.parametrize('permissions, links_to_be_shown, permissions_warning_to_be_shown', [ @pytest.mark.parametrize('permissions, links_to_be_shown, permissions_warning_to_be_shown', [
( (
['view_activity'], ['view_activity'],