diff --git a/app/main/views/templates.py b/app/main/views/templates.py index b0f5a4a76..31bf4a390 100644 --- a/app/main/views/templates.py +++ b/app/main/views/templates.py @@ -262,12 +262,7 @@ def edit_service_template(service_id, template_id): return render_template( 'views/templates/breaking-change.html', template_change=template_change, - new_template={ - 'name': form.name.data, - 'subject': subject, - 'content': form.template_content.data, - 'id': new_template.id - }, + new_template=new_template, column_headings=list(ascii_uppercase[:len(new_template.placeholders) + 1]), example_rows=[ first_column_headings[new_template.template_type] + list(new_template.placeholders), diff --git a/app/templates/views/templates/breaking-change.html b/app/templates/views/templates/breaking-change.html index 6ca08fa25..b6c76140e 100644 --- a/app/templates/views/templates/breaking-change.html +++ b/app/templates/views/templates/breaking-change.html @@ -41,7 +41,8 @@

When you send messages using this template you’ll need - {{ new_template.placeholders|length + 1 }} columns of data: + {{ new_template.placeholders|length + 1 }} + column{{ 's' if new_template.placeholders|length > 0 else '' }} of data:

diff --git a/tests/app/main/views/test_templates.py b/tests/app/main/views/test_templates.py index 6ecf09309..639b86280 100644 --- a/tests/app/main/views/test_templates.py +++ b/tests/app/main/views/test_templates.py @@ -9,6 +9,7 @@ from freezegun import freeze_time from notifications_python_client.errors import HTTPError from tests.conftest import service_one as create_sample_service from tests import validate_route_permission, template_json, single_notification_json +from tests.app.test_utils import normalize_spaces from app.main.views.templates import get_last_use_message, get_human_readable_delta @@ -262,7 +263,7 @@ def test_should_show_interstitial_when_making_breaking_change( data={ 'id': template_id, 'name': "new name", - 'template_content': "hello", + 'template_content': "hello ((name)) lets talk about ((thing))", 'template_type': 'email', 'subject': 'reminder', 'service': service_id, @@ -276,10 +277,17 @@ def test_should_show_interstitial_when_making_breaking_change( assert page.find('a', {'class': 'page-footer-back-link'})['href'] == url_for(".edit_service_template", service_id=service_id, template_id=template_id) + for index, p in enumerate([ + 'You removed ((date))', + 'You added ((name))', + 'When you send messages using this template you’ll need 3 columns of data:', + ]): + assert normalize_spaces(page.select('main p')[index].text) == p + for key, value in { 'name': 'new name', 'subject': 'reminder', - 'template_content': 'hello', + 'template_content': 'hello ((name)) lets talk about ((thing))', 'confirm': 'true' }.items(): assert page.find('input', {'name': key})['value'] == value