darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-02 17:48:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add support for new template statistics API response

Browse Source 
The new API response for template statistics returns separate
count for each status. We get rid of template stats for cancelled
notifications and group the rest of the statuses together.
This commit is contained in:
Pea Tyczynska
2019-01-15 16:19:23 +00:00
parent 46bfb541c8
commit 4fe239abb2
3 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/app/main/views/test_dashboard.py
View File

@@ -35,19 +35,22 @@ stub_template_stats = [
'template_type': 'sms',
'template_name': 'one',
'template_id': 'id-1',
'count': 100
'count': 100,
'is_precompiled_letter': False
},
{
'template_type': 'email',
'template_name': 'two',
'template_id': 'id-2',
'count': 200
'count': 200,
'is_precompiled_letter': False
},
{
'template_type': 'letter',
'template_name': 'three',
'template_id': 'id-3',
'count': 300
'count': 300,
'is_precompiled_letter': False
},
{
'template_type': 'letter',
@@ -1033,8 +1036,8 @@ def test_route_for_service_permissions(
def test_aggregate_template_stats():
from app.main.views.dashboard import aggregate_usage
expected = aggregate_usage(copy.deepcopy(stub_template_stats))
from app.main.views.dashboard import aggregate_template_usage
expected = aggregate_template_usage(copy.deepcopy(stub_template_stats))
assert len(expected) == 4
assert expected[0]['template_name'] == 'four'

2
tests/conftest.py
View File

@@ -2268,7 +2268,7 @@ def mock_get_template_statistics(mocker, service_one, fake_uuid):
"template_name": template['name'],
"template_type": template['template_type'],
"template_id": template['id'],
"day": "2016-04-04"
"is_precompiled_letter": False
}
def _get_stats(service_id, limit_days=None):