darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-27 11:19:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add descriptive links to /service-settings/sms-senders page

Browse Source 
The links had no descriptive text, so all read 'Change'. This adds
hidden text specific to the item they relate to.
This commit is contained in:
Katie Smith
2021-02-23 14:25:33 +00:00
parent 0416b841b3
commit 4f7b08512a
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/app/main/views/test_service_settings.py
View File

@@ -2192,7 +2192,7 @@ def test_and_more_hint_appears_on_settings_with_more_than_just_a_single_sender(
@pytest.mark.parametrize('sender_list_page, index, expected_output', [
('main.service_email_reply_to', 0, 'test@example.com (default) Change test@example.com'),
('main.service_letter_contact_details', 1, '1 Example Street (default) Change'),
('main.service_sms_senders', 0, 'GOVUK (default) Change')
('main.service_sms_senders', 0, 'GOVUK (default) Change GOVUK')
])
def test_api_ids_dont_show_on_option_pages_with_a_single_sender(
client_request,
@@ -2246,9 +2246,9 @@ def test_api_ids_dont_show_on_option_pages_with_a_single_sender(
'app.service_api_client.get_sms_senders',
create_multiple_sms_senders(),
[
'Example (default and receives replies) Change ID: 1234',
'Example 2 Change ID: 5678',
'Example 3 Change ID: 9457',
'Example (default and receives replies) Change Example ID: 1234',
'Example 2 Change Example 2 ID: 5678',
'Example 3 Change Example 3 ID: 9457',
],
),
]