mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-08-25 00:33:58 -04:00
Don’t allow paragraphs without class attribute
All paragraphs should have class="govuk-body", or be otherwise custom-styled. This commit adds some extra checks to our test fixture that looks for paragraphs that don’t have any styling. Our test coverage is pretty good, so this should check almost all pages, and prevent regressions. I’ve done this in such a way that it can be extended for other elements (e.g. links) in the future.
This commit is contained in:
@@ -14,7 +14,7 @@
|
||||
{% call banner_wrapper(type='dangerous') %}
|
||||
<h1 class="banner-title">{{ error.title }}</h1>
|
||||
{% if error.detail %}
|
||||
<p>{{ error.detail | safe }}</p>
|
||||
<p class="govuk-body">{{ error.detail | safe }}</p>
|
||||
{% endif %}
|
||||
{% endcall %}
|
||||
{% else %}
|
||||
@@ -22,11 +22,11 @@
|
||||
'Upload a letter',
|
||||
back_link=url_for('main.uploads', service_id=current_service.id)
|
||||
) }}
|
||||
<p>Upload a single letter as a PDF and we’ll print, pack and post it for you.</p>
|
||||
<p>You can use this feature if you send a lot of one-off letters or if our reusable letter templates do not meet your needs.</p>
|
||||
<p class="govuk-body">Upload a single letter as a PDF and we’ll print, pack and post it for you.</p>
|
||||
<p class="govuk-body">You can use this feature if you send a lot of one-off letters or if our reusable letter templates do not meet your needs.</p>
|
||||
{% endif %}
|
||||
|
||||
<p>
|
||||
<p class="govuk-body">
|
||||
{{ file_upload(
|
||||
form.file,
|
||||
action=url_for('main.upload_letter', service_id=current_service.id),
|
||||
@@ -37,9 +37,9 @@
|
||||
|
||||
<h2 class="heading-medium">Your file must meet our letter specification</h2>
|
||||
|
||||
<p>The content of your letter must appear inside the printable area.</p>
|
||||
<p class="govuk-body">The content of your letter must appear inside the printable area.</p>
|
||||
|
||||
<p>Your file must be:</p>
|
||||
<p class="govuk-body">Your file must be:</p>
|
||||
|
||||
<ul class="list list-bullet">
|
||||
<li>a PDF</li>
|
||||
@@ -48,7 +48,7 @@
|
||||
<li>smaller than 2MB</li>
|
||||
</ul>
|
||||
|
||||
<p>To help you set up your letter, you can download our <a class="govuk-link govuk-link--no-visited-state" href="{{ url_for('.letter_spec') }}">letter specification document (PDF)</a>.</p>
|
||||
<p class="govuk-body">To help you set up your letter, you can download our <a class="govuk-link govuk-link--no-visited-state" href="{{ url_for('.letter_spec') }}">letter specification document (PDF)</a>.</p>
|
||||
</div>
|
||||
</div>
|
||||
{% endblock %}
|
||||
|
||||
@@ -29,7 +29,7 @@
|
||||
<h1 class='banner-title' data-module="track-error" data-error-type="Too many rows" data-error-label="{{ upload_id }}">
|
||||
Your file has too many rows
|
||||
</h1>
|
||||
<p>
|
||||
<p class="govuk-body">
|
||||
Notify can store files up to
|
||||
{{ "{:,}".format(recipients.max_rows) }} rows in size. Your
|
||||
file has {{ "{:,}".format(recipients|length) }} rows.
|
||||
@@ -42,7 +42,7 @@
|
||||
{{ 'this' if recipients|length == 1 else 'these' }}
|
||||
{{ recipient_count_label(recipients|length, recipients.template_type) }}
|
||||
</h1>
|
||||
<p>
|
||||
<p class="govuk-body">
|
||||
In <a class="govuk-link govuk-link--no-visited-state" href="{{ url_for('.trial_mode_new') }}">trial mode</a> you can only
|
||||
send to yourself and members of your team
|
||||
</p>
|
||||
|
||||
@@ -27,14 +27,14 @@
|
||||
<h1 class='banner-title' data-module="track-error" data-error-type="Bad rows" data-error-label="{{ upload_id }}">
|
||||
There’s a problem with {{ original_file_name }}
|
||||
</h1>
|
||||
<p>
|
||||
<p class="govuk-body">
|
||||
You need to {{ row_errors[0] }}.
|
||||
</p>
|
||||
{% else %}
|
||||
<h1 class='banner-title' data-module="track-error" data-error-type="Bad rows" data-error-label="{{ upload_id }}">
|
||||
There are some problems with {{ original_file_name }}
|
||||
</h1>
|
||||
<p>
|
||||
<p class="govuk-body">
|
||||
You need to:
|
||||
</p>
|
||||
<ul class="list-bullet">
|
||||
|
||||
@@ -29,7 +29,7 @@
|
||||
<h1 class='banner-title' data-module="track-error" data-error-type="No rows" data-error-label="{{ upload_id }}">
|
||||
Your file is missing some rows
|
||||
</h1>
|
||||
<p>
|
||||
<p class="govuk-body">
|
||||
It needs at least one row of data
|
||||
{%- if template_type %}.{% else %}, in a column called ‘email address’ or ‘phone number’.{% endif %}
|
||||
</p>
|
||||
@@ -39,7 +39,7 @@
|
||||
<h1 class='banner-title' data-module="track-error" data-error-type="Too many rows" data-error-label="{{ upload_id }}">
|
||||
Your file needs a column called ‘email address’ or ‘phone number’.
|
||||
</h1>
|
||||
<p>
|
||||
<p class="govuk-body">
|
||||
Right now it has 1 column called ‘{{ recipients._raw_column_headers[0] }}’.
|
||||
</p>
|
||||
|
||||
@@ -48,10 +48,10 @@
|
||||
<h1 class='banner-title' data-module="track-error" data-error-type="Too many rows" data-error-label="{{ upload_id }}">
|
||||
Your file has too many columns
|
||||
</h1>
|
||||
<p>
|
||||
<p class="govuk-body">
|
||||
It needs to have 1 column, called ‘email address’ or ‘phone number’.
|
||||
</p>
|
||||
<p>
|
||||
<p class="govuk-body">
|
||||
Right now it has {{ recipients._raw_column_headers|length }} columns called {{ recipients._raw_column_headers | formatted_list }}.
|
||||
</p>
|
||||
|
||||
|
||||
@@ -13,7 +13,7 @@
|
||||
{% call banner_wrapper(type='dangerous') %}
|
||||
<h1 class="banner-title">{{ error.title }}</h1>
|
||||
{% if error.detail %}
|
||||
<p>{{ error.detail | safe }}</p>
|
||||
<p class="govuk-body">{{ error.detail | safe }}</p>
|
||||
{% endif %}
|
||||
{% endcall %}
|
||||
{% else %}
|
||||
|
||||
Reference in New Issue
Block a user