darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 16:24:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don’t allow paragraphs without class attribute

Browse Source 
All paragraphs should have class="govuk-body", or be otherwise
custom-styled. This commit adds some extra checks to our test fixture
that looks for paragraphs that don’t have any styling. Our test coverage
is pretty good, so this should check almost all pages, and prevent
regressions.

I’ve done this in such a way that it can be extended for other elements
(e.g. links) in the future.
This commit is contained in:
Chris Hill-Scott
2020-05-29 17:11:01 +01:00
parent 82ec03e263
commit 4df99bd27f
134 changed files with 517 additions and 497 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/templates/views/support/index.html
View File

@@ -10,7 +10,7 @@
{% block maincolumn_content %}
<h1 class="heading-large">Support</h1>
<p>We provide 24-hour online support for teams with a live service on GOV.UK&nbsp;Notify.</p>
<p class="govuk-body">We provide 24-hour online support for teams with a live service on GOV.UK&nbsp;Notify.</p>
{% call form_wrapper() %}
{% if current_user.is_authenticated %}
@@ -24,19 +24,19 @@
{{ page_footer('Continue') }}
{% endcall %}
<p>You can also <a class="govuk-link govuk-link--no-visited-state" href="https://ukgovernmentdigital.slack.com/messages/C0E1ADVPC">contact us on Slack</a>.</p>
<p class="govuk-body">You can also <a class="govuk-link govuk-link--no-visited-state" href="https://ukgovernmentdigital.slack.com/messages/C0E1ADVPC">contact us on Slack</a>.</p>
<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
<h2 class="heading-medium">Office hours</h2>
<p>Our office hours are 9:30am to 5:30pm, Monday to Friday.</p>
<p>When you report a problem in office hours, we’ll aim to read it within 30 minutes and reply within one working day.</p>
<p class="govuk-body">Our office hours are 9:30am to 5:30pm, Monday to Friday.</p>
<p class="govuk-body">When you report a problem in office hours, we’ll aim to read it within 30 minutes and reply within one working day.</p>
<h2 class="heading-medium">Out-of-hours</h2>
<p>Outside office hours, response times depend on whether you’re reporting an emergency.</p>
<p>If it’s an emergency, we’ll reply within 30 minutes and update you every hour until the problem’s fixed.</p>
<p>If your problem is not an emergency, we’ll reply within one working day.</p>
<p>A problem is only classed as an emergency if:</p>
<p class="govuk-body">Outside office hours, response times depend on whether you’re reporting an emergency.</p>
<p class="govuk-body">If it’s an emergency, we’ll reply within 30 minutes and update you every hour until the problem’s fixed.</p>
<p class="govuk-body">If your problem is not an emergency, we’ll reply within one working day.</p>
<p class="govuk-body">A problem is only classed as an emergency if:</p>
<ul class="list list-bullet">
<li>nobody on your team can sign in</li>
<li>a ‘technical difficulties’ error appears when you try to upload a file</li>