darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-02 17:48:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don’t allow paragraphs without class attribute

Browse Source 
All paragraphs should have class="govuk-body", or be otherwise
custom-styled. This commit adds some extra checks to our test fixture
that looks for paragraphs that don’t have any styling. Our test coverage
is pretty good, so this should check almost all pages, and prevent
regressions.

I’ve done this in such a way that it can be extended for other elements
(e.g. links) in the future.
This commit is contained in:
Chris Hill-Scott
2020-05-29 17:11:01 +01:00
parent 82ec03e263
commit 4df99bd27f
134 changed files with 517 additions and 497 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/templates/views/manage-users/confirm-edit-user-email.html
View File

@@ -17,11 +17,11 @@
<div class="govuk-grid-row">
<div class="govuk-grid-column-full">
{% call form_wrapper() %}
<p>New email address:</p>
<p class="govuk-body">New email address:</p>
<div class="panel panel-border-wide bottom-gutter">
<p>{{ new_email }}</p>
<p class="govuk-body">{{ new_email }}</p>
</div>
<p>We will send {{ user.name }} an email to tell them about the change.</p>
<p class="govuk-body">We will send {{ user.name }} an email to tell them about the change.</p>
{{ page_footer('Confirm') }}
{% endcall %}
</div>

6
app/templates/views/manage-users/confirm-edit-user-mobile-number.html
View File

@@ -17,11 +17,11 @@
<div class="govuk-grid-row">
<div class="govuk-grid-column-full">
{% call form_wrapper() %}
<p>New mobile number:</p>
<p class="govuk-body">New mobile number:</p>
<div class="panel panel-border-wide bottom-gutter">
<p>{{ new_mobile_number }}</p>
<p class="govuk-body">{{ new_mobile_number }}</p>
</div>
<p>We will send {{ user.name }} a text message to tell them about the change.</p>
<p class="govuk-body">We will send {{ user.name }} a text message to tell them about the change.</p>
{{ page_footer('Confirm') }}
{% endcall %}
</div>

2
app/templates/views/manage-users/edit-user-email.html
View File

@@ -15,7 +15,7 @@
back_link=url_for('main.edit_user_permissions', service_id=current_service.id, user_id=user.id)
) }}
<p id="user_name">This will change the email address for {{ user.name }}.</p>
<p class="govuk-body" id="user_name">This will change the email address for {{ user.name }}.</p>
{% call form_wrapper() %}
{{ textbox(form.email_address, width='1-1', safe_error_message=True) }}
{{ page_footer('Save') }}

2
app/templates/views/manage-users/edit-user-mobile.html
View File

@@ -15,7 +15,7 @@
back_link=url_for('main.edit_user_permissions', service_id=current_service.id, user_id=user.id)
) }}
<p id="user_name">This will change the mobile number for {{ user.name }}.</p>
<p class="govuk-body" id="user_name">This will change the mobile number for {{ user.name }}.</p>
<div class="govuk-grid-row">
<div class="govuk-grid-column-three-quarters">
{% call form_wrapper(class="extra-tracking") %}