darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-07 14:38:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don’t allow paragraphs without class attribute

Browse Source 
All paragraphs should have class="govuk-body", or be otherwise
custom-styled. This commit adds some extra checks to our test fixture
that looks for paragraphs that don’t have any styling. Our test coverage
is pretty good, so this should check almost all pages, and prevent
regressions.

I’ve done this in such a way that it can be extended for other elements
(e.g. links) in the future.
This commit is contained in:
Chris Hill-Scott
2020-05-29 17:11:01 +01:00
parent 82ec03e263
commit 4df99bd27f
134 changed files with 517 additions and 497 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/templates/views/cookies.html
View File

@@ -21,10 +21,10 @@
<p class="summary">
Cookies are small files saved on your phone, tablet or computer when you visit a website.
</p>
<p>We use cookies to make GOV.UK Notify work and collect information about how you use our service.</p>
<p class="govuk-body">We use cookies to make GOV.UK Notify work and collect information about how you use our service.</p>
<h2 class="heading-medium">Essential cookies</h2>
<p>
<p class="govuk-body">
Essential cookies keep your information secure while you use Notify. We do not need to ask permission to use them.
</p>
<table>
@@ -63,13 +63,13 @@
</table>
<h2 class="heading-medium">Analytics cookies (optional)</h2>
<p>
<p class="govuk-body">
With your permission, we use Google Analytics to collect data about how you use Notify. This information helps us to improve our service.
</p>
<p>
<p class="govuk-body">
Google is not allowed to use or share our analytics data with anyone.
</p>
<p>
<p class="govuk-body">
Google Analytics stores anonymised information about:
</p>
<ul class="govuk-list govuk-list--bullet">
@@ -113,7 +113,7 @@
</table>
<div class="cookie-settings__no-js">
<h2 class="govuk-heading-s govuk-!-margin-top-6">Do you want to accept analytics cookies?</h2>
<p>We use Javascript to set our analytics cookies. Unfortunately Javascript is not running on your browser, so you cannot change your settings. You can try:</p>
<p class="govuk-body">We use Javascript to set our analytics cookies. Unfortunately Javascript is not running on your browser, so you cannot change your settings. You can try:</p>
<ul class="govuk-list govuk-list--bullet">
<li>reloading the page</li>
<li>turning on Javascript in your browser</li>