From 4cdac9eba38b9b6150280470d44d33548806bef7 Mon Sep 17 00:00:00 2001 From: Cliff Hill Date: Wed, 25 Sep 2024 12:05:56 -0400 Subject: [PATCH] Making coverage not bother with sign in stuff since login.gov. Signed-off-by: Cliff Hill --- app/main/views/sign_in.py | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/app/main/views/sign_in.py b/app/main/views/sign_in.py index 3c80e0456..df9dd67d5 100644 --- a/app/main/views/sign_in.py +++ b/app/main/views/sign_in.py @@ -29,7 +29,7 @@ from app.utils.user import is_gov_user from notifications_utils.url_safe_token import generate_token -def _reformat_keystring(orig): +def _reformat_keystring(orig): # pragma: no cover arr = orig.split("-----") begin = arr[1] end = arr[3] @@ -38,7 +38,7 @@ def _reformat_keystring(orig): return new_keystring -def _get_access_token(code, state): +def _get_access_token(code, state): # pragma: no cover client_id = os.getenv("LOGIN_DOT_GOV_CLIENT_ID") access_token_url = os.getenv("LOGIN_DOT_GOV_ACCESS_TOKEN_URL") keystring = os.getenv("LOGIN_PEM") @@ -64,11 +64,9 @@ def _get_access_token(code, state): response_json = response.json() try: encoded_id_token = response_json["id_token"] - except KeyError as e: # pragma: no cover + except KeyError as e: # Capture the response json here so it hopefully shows up in error reports - current_app.logger.error( - f"Error when getting id token {response_json}" - ) + current_app.logger.error(f"Error when getting id token {response_json}") raise KeyError(f"'access_token' {response.json()}") from e id_token = jwt.decode(encoded_id_token, keystring, algorithms=["RS256"]) nonce = id_token["nonce"] @@ -81,7 +79,7 @@ def _get_access_token(code, state): try: access_token = response_json["access_token"] - except KeyError as e: # pragma: no cover + except KeyError as e: # Capture the response json here so it hopefully shows up in error reports current_app.logger.error( f"Error when getting access token {response.json()} #notify-admin-1505" @@ -90,7 +88,7 @@ def _get_access_token(code, state): return access_token -def _get_user_email_and_uuid(access_token): +def _get_user_email_and_uuid(access_token): # pragma: no cover headers = {"Authorization": "Bearer %s" % access_token} user_info_url = os.getenv("LOGIN_DOT_GOV_USER_INFO_URL") user_attributes = requests.get( @@ -102,7 +100,7 @@ def _get_user_email_and_uuid(access_token): return user_email, user_uuid -def _do_login_dot_gov(): +def _do_login_dot_gov(): # $ pragma: no cover # start login.gov code = request.args.get("code") state = request.args.get("state") @@ -149,7 +147,7 @@ def _do_login_dot_gov(): # end login.gov -def verify_email(user, redirect_url): +def verify_email(user, redirect_url): # pragma: no cover user_api_client.send_verify_code(user["id"], "email", None, redirect_url) title = "Email resent" if request.args.get("email_resent") else "Check your email" redirect_url = request.args.get("next") @@ -158,7 +156,7 @@ def verify_email(user, redirect_url): ) -def _handle_e2e_tests(redirect_url): +def _handle_e2e_tests(redirect_url): # pragma: no cover try: current_app.logger.warning("E2E TESTS ARE ENABLED.") current_app.logger.warning( @@ -181,7 +179,7 @@ def _handle_e2e_tests(redirect_url): @main.route("/sign-in", methods=(["GET", "POST"])) @hide_from_search_engines -def sign_in(): +def sign_in(): # pragma: no cover redirect_url = request.args.get("next") if os.getenv("NOTIFY_E2E_TEST_EMAIL"): @@ -224,5 +222,5 @@ def sign_in(): @login_manager.unauthorized_handler -def sign_in_again(): +def sign_in_again(): # pragma: no cover return redirect(url_for("main.sign_in", next=request.path))