From 44f42c8916a0d84450a1b942708a3d87da68bc11 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Mon, 9 Apr 2018 13:40:03 +0100 Subject: [PATCH] Be clearer about the templates needed to go live MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adding a ‘testing’ template it not enough. It needs to have some real looking content, so that we can: - work out what a service is doing - assess whether that’s a reasonable (ie meeting the terms of use) thing to be doing with Notify At the moment we’re having to go back to services quite a lot when they request to go live and ask them for this stuff. --- .../views/service-settings/request-to-go-live.html | 2 +- tests/app/main/views/test_service_settings.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/templates/views/service-settings/request-to-go-live.html b/app/templates/views/service-settings/request-to-go-live.html index 27c7bb16e..4423de949 100644 --- a/app/templates/views/service-settings/request-to-go-live.html +++ b/app/templates/views/service-settings/request-to-go-live.html @@ -26,7 +26,7 @@ ) }} {{ tick_cross_done_not_done( has_templates, - 'Create some templates'.format( + 'Create templates showing the kind of messages you plan to send'.format( url_for('main.choose_template', service_id=current_service.id) )|safe, ) }} diff --git a/tests/app/main/views/test_service_settings.py b/tests/app/main/views/test_service_settings.py index a013066ec..c76aead72 100644 --- a/tests/app/main/views/test_service_settings.py +++ b/tests/app/main/views/test_service_settings.py @@ -460,9 +460,9 @@ def test_should_raise_duplicate_name_handled( (2, 'Done: Have more than one team member with the ‘Manage service’ permission'), ]) @pytest.mark.parametrize('count_of_templates, expected_templates_checklist_item', [ - (0, 'Not done: Create some templates'), - (1, 'Done: Create some templates'), - (2, 'Done: Create some templates'), + (0, 'Not done: Create templates showing the kind of messages you plan to send'), + (1, 'Done: Create templates showing the kind of messages you plan to send'), + (2, 'Done: Create templates showing the kind of messages you plan to send'), ]) @pytest.mark.parametrize('count_of_email_templates, reply_to_email_addresses, expected_reply_to_checklist_item', [ pytest.mark.xfail((0, [], ''), raises=IndexError),