mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-09-11 10:28:41 -04:00
remove name from copy-to-clipboard invocations
name is designed for a human readable description of what the thing you're copying belongs to. (while thing is supposed to describe what the value represents. For example on the reply-to email address page, thing="ID" because you're copying a uuid, and name is the actual name of the email address. So the talkback speech will read out "copy ID to clipboard for my@email.com, button". However, in our case, there's no need to add what the context is for since each copyable item on the page is something different (a sort code, a VAT number, etc). Removing the name makes the talkback just read "Copy sort code to clipboard", which is what we want. However the macro also only shows a header if the name is present, so we have to add the header manually.
This commit is contained in:
@@ -53,7 +53,6 @@
|
||||
<div class="govuk-!-margin-bottom-4">
|
||||
{{ copy_to_clipboard(
|
||||
'GB 88 88 010 80',
|
||||
name=None,
|
||||
thing='<abbr title="Value Added Tax">VAT</abbr> number',
|
||||
) }}
|
||||
</div>
|
||||
@@ -79,34 +78,46 @@
|
||||
Cabinet Office
|
||||
</p>
|
||||
|
||||
<h3 class="heading-small">
|
||||
Account number
|
||||
</h3>
|
||||
|
||||
<div class="govuk-!-margin-bottom-4">
|
||||
{{ copy_to_clipboard(
|
||||
billing_details['account_number'],
|
||||
name='Account number',
|
||||
thing='account number',
|
||||
) }}
|
||||
</div>
|
||||
|
||||
<h3 class="heading-small">
|
||||
Sort code
|
||||
</h3>
|
||||
|
||||
<div class="govuk-!-margin-bottom-4">
|
||||
{{ copy_to_clipboard(
|
||||
billing_details['sort_code'],
|
||||
name='Sort code',
|
||||
thing='sort code',
|
||||
) }}
|
||||
</div>
|
||||
|
||||
|
||||
<h3 class="heading-small">
|
||||
<abbr title="International Bank Account Number">IBAN</abbr>
|
||||
</h3>
|
||||
<div class="govuk-!-margin-bottom-4">
|
||||
{{ copy_to_clipboard(
|
||||
billing_details['IBAN'],
|
||||
name='IBAN',
|
||||
thing='IBAN',
|
||||
) }}
|
||||
</div>
|
||||
|
||||
<h3 class="heading-small">
|
||||
Swift code
|
||||
</h3>
|
||||
|
||||
<div class="govuk-!-margin-bottom-4">
|
||||
{{ copy_to_clipboard(
|
||||
billing_details['swift'],
|
||||
name='Swift code',
|
||||
thing='Swift code',
|
||||
) }}
|
||||
</div>
|
||||
|
||||
Reference in New Issue
Block a user