Merge pull request #1024 from alphagov/add-letters-templates-2

Let users upload a CSV file of addresses against a letter template

tests/app/main/views/test_letters.py

@@ -1,34 +1,51 @@
 import pytest
 from flask import url_for
+from functools import partial
 
 from tests import service_json
 
+letters_urls = [
+    partial(url_for, 'main.choose_template', template_type='letter'),
+    partial(url_for, 'main.add_service_template', template_type='letter'),
+]
 
+
+@pytest.mark.parametrize('url', letters_urls)
 @pytest.mark.parametrize('can_send_letters, response_code', [
     (True, 200),
     (False, 403)
 ])
-def test_letters_access_restricted(logged_in_client, mocker, can_send_letters, response_code):
+def test_letters_access_restricted(
+    logged_in_client,
+    mocker,
+    can_send_letters,
+    response_code,
+    mock_get_service_templates,
+    url
+):
     service = service_json(can_send_letters=can_send_letters)
     mocker.patch('app.service_api_client.get_service', return_value={"data": service})
 
-    response = logged_in_client.get(url_for('main.letters', service_id=service['id']))
+    response = logged_in_client.get(url(service_id=service['id']))
 
     assert response.status_code == response_code
 
 
+@pytest.mark.parametrize('url', letters_urls)
 def test_letters_lets_in_without_permission(
     client,
     mocker,
     mock_login,
     mock_has_permissions,
     api_user_active,
+    mock_get_service_templates,
+    url
 ):
     service = service_json(can_send_letters=True)
     mocker.patch('app.service_api_client.get_service', return_value={"data": service})
 
     client.login(api_user_active)
-    response = client.get(url_for('main.letters', service_id=service['id']))
+    response = client.get(url(service_id=service['id']))
 
     assert api_user_active.permissions == {}
     assert response.status_code == 200

tests/app/main/views/test_send.py

@@ -405,6 +405,33 @@ def test_create_job_should_call_api(
     )
 
 
+def test_cant_start_letters_job(
+    app_,
+    client,
+    service_one,
+    mock_get_service,
+    active_user_with_permissions,
+    mock_create_job,
+    mock_get_service_letter_template,
+    mocker,
+    fake_uuid
+):
+    client.login(active_user_with_permissions, mocker, service_one)
+    with client.session_transaction() as session:
+        session['upload_data'] = {
+            'original_file_name': 'example.csv',
+            'template_id': fake_uuid,
+            'notification_count': 123,
+            'valid': True
+        }
+    response = client.post(
+        url_for('main.start_job', service_id=fake_uuid, upload_id=fake_uuid),
+        data={}
+    )
+    assert response.status_code == 403
+    mock_create_job.assert_not_called()
+
+
 def test_check_messages_should_revalidate_file_when_uploading_file(
     app_,
     service_one,

tests/conftest.py

@@ -335,6 +335,21 @@ def mock_get_service_email_template(mocker):
         'app.service_api_client.get_service_template', side_effect=_create)
 
 
+@pytest.fixture(scope='function')
+def mock_get_service_letter_template(mocker):
+    def _create(service_id, template_id):
+        template = template_json(
+            service_id,
+            template_id,
+            "Two week reminder",
+            "letter",
+            "Your vehicle tax is about to expire", "Subject")
+        return {'data': template}
+
+    return mocker.patch(
+        'app.service_api_client.get_service_template', side_effect=_create)
+
+
 @pytest.fixture(scope='function')
 def mock_create_service_template(mocker, fake_uuid):
     def _create(name, type_, content, service, subject=None):