darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-29 04:09:07 -04:00
Code Issues Packages Projects Releases Wiki Activity

Handling template content size error. All tests passing.

Browse Source
This commit is contained in:
Nicholas Staples
2016-04-29 09:38:59 +01:00
parent fbf30129b0
commit 471eac209e
4 changed files with 151 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
tests/app/main/views/test_templates.py
View File

@@ -67,6 +67,75 @@ def test_should_redirect_when_saving_a_template(app_,
template_id, name, 'sms', content, service_id, None)
def test_should_not_create_too_big_template(app_,
api_user_active,
mock_login,
mock_get_service_template,
mock_get_user,
mock_get_service,
mock_get_user_by_email,
mock_create_service_template_content_too_big,
mock_has_permissions,
fake_uuid):
with app_.test_request_context():
with app_.test_client() as client:
client.login(api_user_active)
service_id = fake_uuid
template_type = 'sms'
data = {
'name': "new name",
'template_content': "template content",
'template_type': template_type,
'service': service_id
}
resp = client.post(url_for(
'.add_service_template',
service_id=service_id,
template_type=template_type
), data=data)
assert resp.status_code == 200
assert (
"Content has a character count greater"
" than the limit of 459"
) in resp.get_data(as_text=True)
def test_should_not_update_too_big_template(app_,
api_user_active,
mock_login,
mock_get_service_template,
mock_get_user,
mock_get_service,
mock_get_user_by_email,
mock_update_service_template_400_content_too_big,
mock_has_permissions,
fake_uuid):
with app_.test_request_context():
with app_.test_client() as client:
client.login(api_user_active)
service_id = fake_uuid
template_type = 'sms'
template_id = fake_uuid
data = {
'id': fake_uuid,
'name': "new name",
'template_content': "template content",
'service': service_id,
'template_type': 'sms'
}
resp = client.post(url_for(
'.edit_service_template',
service_id=service_id,
template_id=template_id), data=data)
assert resp.status_code == 200
assert (
"Content has a character count greater"
" than the limit of 459"
) in resp.get_data(as_text=True)
def test_should_redirect_when_saving_a_template_email(app_,
api_user_active,
mock_login,

38
tests/conftest.py
View File

@@ -207,7 +207,7 @@ def mock_get_service_email_template(mocker):
@pytest.fixture(scope='function')
def mock_create_service_template(mocker, fake_uuid):
def _create(name, type_, content, service):
def _create(name, type_, content, service, subject=None):
template = template_json(
fake_uuid, name, type_, content, service)
return {'data': template}
@@ -229,6 +229,42 @@ def mock_update_service_template(mocker):
side_effect=_update)
@pytest.fixture(scope='function')
def mock_create_service_template_content_too_big(mocker):
def _create(name, type_, content, service, subject=None):
json_mock = Mock(return_value={
'message': {'content': ["Content has a character count greater than the limit of 459"]},
'result': 'error'
})
resp_mock = Mock(status_code=400, json=json_mock)
http_error = HTTPError(
response=resp_mock,
message={'content': ["Content has a character count greater than the limit of 459"]})
raise http_error
return mocker.patch(
'app.service_api_client.create_service_template',
side_effect=_create)
@pytest.fixture(scope='function')
def mock_update_service_template_400_content_too_big(mocker):
def _update(id_, name, type_, content, service, subject=None):
json_mock = Mock(return_value={
'message': {'content': ["Content has a character count greater than the limit of 459"]},
'result': 'error'
})
resp_mock = Mock(status_code=400, json=json_mock)
http_error = HTTPError(
response=resp_mock,
message={'content': ["Content has a character count greater than the limit of 459"]})
raise http_error
return mocker.patch(
'app.service_api_client.update_service_template',
side_effect=_update)
@pytest.fixture(scope='function')
def mock_get_service_templates(mocker):
uuid1 = str(generate_uuid())