darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-13 09:50:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fixes for updateContent based on PR comments

Browse Source 
Includes the following:

Guard for adding duplicate classNames

Stops the code that allows classNames to persist
across updates to the component HTML from adding a
className multiple times to the list of those to
persist. From this comment on the associated pull
request:

https://github.com/alphagov/notifications-admin/pull/4155#discussion_r804639058

Add comment explaining guard for operations on
elements no longer in the DOM

The value of this guard can be unclear and why it
is needed so we add a comment to explain this.
From this comment on the associated pull request:

https://github.com/alphagov/notifications-admin/pull/4155#discussion_r804697189
This commit is contained in:
Tom Byers
2022-02-15 11:05:28 +00:00
parent e310ff3469
commit 467be3a339
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/javascripts/updateContent.js
View File

@@ -17,7 +17,9 @@
_classNames: [],
_$els: [],
addClassName: function (className) {
this._classNames.push(className);
if (this._classNames.indexOf(className) === -1) {
this._classNames.push(className);
}
},
remove: function () {
this._classNames.forEach(className => {
@@ -31,6 +33,8 @@
this._classNames.forEach((className, index) => {
var $el = this._$els[index];
// Avoid updating elements that are no longer present.
// elements removed will still exist in memory but won't be attached to the DOM any more
if (global.document.body.contains($el.get(0))) {
$el.addClass(className);
}